How to un-ignore the ignored rubocop cops? about haml-lint HOT 6 CLOSED

Hey @maxjacobson,

Those cops are ignored for a good reason: haml-lint takes some shortcuts when extracting Ruby code from a HAML template, which necessarily results in noise from those cops.

Can you give a specific example of a cop you want to disable?

If you still REALLY want to do this, you just need to redefine the entire list in your local .haml-lint.yml:

linters:
  RuboCop:
    ignored_cops: [] # NOT RECOMMENDED!

from haml-lint.

Hey @sds thanks for getting back to me!

there are a few nitpicky things I was hoping haml-lint would catch:

• the newline character at end of file thing
• tabs instead of spaces for indentation
• 4 spaces instead of 2 spaces for indentation

are you saying it doesn't analyze the file as it is, but first transforms it into some other ruby file, so it wouldn't catch those things necessarily anyway?

thanks!

from haml-lint.

Yes, as part of its preprocessing, haml-lint will convert HAML like this:

- if signed_in?(viewer)
  %span Stuff
  = link_to 'Sign Out', sign_out_path
- else
  .some-class{ class: my_method }= my_method
  = link_to 'Sign In', sign_in_path

...into Ruby like this:

if signed_in?(viewer)
  link_to 'Sign Out', sign_out_path
else
  { class: my_method }
  my_method
  link_to 'Sign In', sign_in_path
end

Notice that the Ruby is somewhat nonsensical. All haml-lint tries to do is preserve the ordering of declarations and uses of variables, as well as the order Ruby that code appears in the template. This means you probably won't have a translation that makes perfect sense.

For things like indentation, it may be possible to munge things into shape but I haven't looked too deeply into that. Right now if you have HAML like the following:

%tag{ some: 'hash', 
      attributes: 'here' }

...it will get extracted as:

{ some: 'hash', attributes: 'here' }

...losing some of the whitespace in the process. This makes it difficult to have it generate correct indentation.

For your request about final newlines, I think it's reasonable for haml-lint to support that first hand via a FinalNewline linter, since RuboCop won't have any idea whether your HAML template ends with a newline or not.

from haml-lint.

Makes total sense, thanks for explaining.

Adding a newline check would be super helpful! What do you think about checking for the presence of a tab character? I think most Rubyists are using spaces, not tabs, so checking for the presence of a tab file character in the source haml file might be useful as well 😄

from haml-lint.

Added a final newline check in 1635c07. Enforcing spaces instead of tabs in indentation was added in #81.

from haml-lint.

Awesome! Thanks a lot @sds

from haml-lint.