Comments (4)
For sure, we can at least factorize __init__
, sample_from_posterior_z
, sample_from_posterior_l
, get_sample_scale
, get_sample_rate
based on the VAE class. I can take care of that. However the forward
methods seems difficult to inherit, so there will be full overriding for VAEC and SVAEC I imagine. I think SVAEC can't inherit anything VAEC: for the __init__
their Classifier has different n_input
, n_ouput
, and for the forward
the only edges in common are already the ones shared with VAE
.
from scvi-tools.
It does look like some parts of the forward
methods for all three classes are shared. e.g.,
and
It'd be good to avoid duplicating these part if possible, by storing them only in the base class (i.e. VAE).
from scvi-tools.
431d066: started doing it.
Not sure, however, about how to factorize forward
method without creating intermediary methods with long arguments list and long signatures.
from scvi-tools.
You're right -- we don't want tiny functions with long argument lists. Maybe fine to have some duplicated code in forward methods then.
from scvi-tools.
Related Issues (20)
- solo.predict() should take an argument to return Non-softmax transformed values, and return logits like previous iterations to allow for non-breaking change that was implemented in 1.1.3 HOT 2
- Update release checklist and documentation for new release workflow HOT 1
- scvi-tools 1.2.0 HOT 3
- Autotuning with Ray: DeprecationWarning: The `RunConfig(local_dir)` argument is deprecated. You should set the `RunConfig(storage_path)` instead. HOT 2
- Use explicit configs instead of kwargs
- autotune throws error for ContrastiveVI (and possibly other external modules) HOT 1
- Fix custom dataloader registry HOT 2
- ModelTuner.fit Returns error: The `RunConfig(local_dir)` argument is deprecated. HOT 10
- Error in model training HOT 2
- Reproducibility issue of MRVI HOT 4
- In Jupyter Notebook on Windows, the kernel keeps crashing when running Model hyperparameter tuning with scVI. HOT 22
- How to increase num_workers in pytorch DataLoader? HOT 1
- error in scanvi_ref HOT 8
- Memory error running CellAssign depending on size of marker gene set reference HOT 8
- lightning dependency critical CVE - Update dependency list, especially for conda which is pinned below the CVE patch HOT 1
- Bugs related to MultiVI HOT 6
- n_proteins Parameter in MultiVI Class HOT 3
- Incompatibility with new anndata 0.10.9 HOT 2
- installation error when import scvi in conda/pip HOT 3
- Fix the progress bar during training models trough tout the tutorials
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scvi-tools.