Git Product home page Git Product logo

Comments (5)

thisandagain avatar thisandagain commented on August 10, 2024

/cc @evhan55 @ericrosenbaum

from scratch-link.

evhan55 avatar evhan55 commented on August 10, 2024

Just leaving a note with some test results:

Microsoft Windows 10 v1803 + Chrome: no crash
Microsoft Windows 10 v1803 + Edge: no crash
MacOS Mojave + Chrome: no crash
MacOS Mojave + Firefox: no crash
MacOS Mojave + Safari: crash

from scratch-link.

knandersen avatar knandersen commented on August 10, 2024

Hey @evhan55, don't know where you are on this, but I just noticed that it's not even necessary to have a connection. Just having a BLE-enabled extension loaded and search for a device makes the browser crash when refreshed.

from scratch-link.

evhan55 avatar evhan55 commented on August 10, 2024

@knandersen Cool, thanks! I haven't looked more into it yet but this is good to know!

from scratch-link.

evhan55 avatar evhan55 commented on August 10, 2024

Testing this today, discovered:

  • Setting window.onbeforeunload = this.disconnect; in the Microbit extension prevents Scratch Link from crashing on a page refresh, essentially fixing the issue. However, @cwillisf believes it's probably best to fix this in Scratch Link itself instead of on the client side
  • window.addEventListener('beforeunload', this.disconnect); also fixes the issue, and is safer if it doesn't override window.onbeforeunload globally

from scratch-link.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.