Switch to the latest sphinx about scrapy HOT 9 CLOSED

@Gallaecio I mean those two elements even have different depth, and #std-setting-HTTPPROXY_AUTH_ENCODING is inside #httpproxy-enabled, so this HTML looks like something that works approximately (because the links are near the place we want) but is not strictly what we want.

from scrapy.

@Rotzbua do you suggest migrating to 7.x later?

from scrapy.

The exception is caused by some change in Sphinx 7.2.0 that leads to a different order of nodes when there are two .. setting directives in a row (index,target,index,target in older versions but index,index,target,target in newer ones) which breaks our code. No idea yet why this happens and if it's expected.

from scrapy.

Bisected to sphinx-doc/sphinx#10478

from scrapy.

sphinx-doc/sphinx#11797

from scrapy.

Per the comment in the upstream issue we need to change the logic in get_setting_target() and it should be relatively easy to do that.

As an aside, I'm not sure if the HTML that is currently generated for multiple setting directives in a row is correct, see e.g. https://docs.scrapy.org/en/latest/topics/downloader-middleware.html#httpproxymiddleware-settings and where are the #std-setting-HTTPPROXY_ENABLED and #std-setting-HTTPPROXY_AUTH_ENCODING elements.

from scrapy.

As an aside, I'm not sure if the HTML that is currently generated for multiple setting directives in a row is correct, see e.g. https://docs.scrapy.org/en/latest/topics/downloader-middleware.html#httpproxymiddleware-settings and where are the #std-setting-HTTPPROXY_ENABLED and #std-setting-HTTPPROXY_AUTH_ENCODING elements.

As far as I know, <span id="…"></span> is a valid approach to set an anchor anywhere on an HTML document.

from scrapy.

@wRAR With Sphinx v7 a lot is being reworked. This leads to many side effects. I would advise you to migrate to the latest v6.

from scrapy.

Fixed by #6200

from scrapy.