Git Product home page Git Product logo

Comments (3)

dy avatar dy commented on August 26, 2024 2

Exactly, usually things with -size suffix, like frameSize etc means size in bytes, and -length means size in units, like samples etc. So frameLength would be kind of conventional, but seems nobody uses that in audio processing, web-audio-api calls it bufferSize. Others call it block, blockSize etc.
frame is easy to type in:

createGenerator(fn, {
    frame: 1024
});

But mb confusing a bit as if it is current frame number. I guess we should leave samplesPerFrame.

from pcm-util.

jamen avatar jamen commented on August 26, 2024

I don't mind being explicit about variable names, having them be as long as you need to describe what you need to.

Do you think it would be confusing without it? I feel like it could be easily mistaken for size in different units like bytes?

from pcm-util.

dy avatar dy commented on August 26, 2024

Following latest practices in regl-line2d, pick-by-alias, defined, regl etc. it seems to be very handy to use aliases for property names. samplesPerFrame is really too verbose to remember (getting back to audiojs after 2 months of detour), and length or frameSize are legitimate synonyms, since there is no place for any other meaning but frame length. Very useful to have f as a shortcut for frequency etc., since it does not introduce ambiguity.
So I would suggest using defined(opts.frameSize, opts.length, opts.samplesPerFrame, default) as a pattern for parsing options across components. That really allows for intuitive API.

from pcm-util.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.