Sourcemaps mapping issue in 2.2.2 about gulp-clean-css HOT 9 CLOSED

@EAnushan thanks for the repo! I was able to reproduce this and can confirm this as an issue. Will publish a fix tomorrow in the AM (EST time zone here)

from gulp-clean-css.

I made some changes regarding path resolution in 2.2.2. I think you'll be okay if you remove what looks like a workaround to solve a defect in my earlier version. Specifically...

.write(undefined, {
    sourceRoot: path.join(path.relative(options.css_min_dir, options.css_dir), path.sep)
}))

...looks like a code smell. I wrote a test to mock out the simple pipeline you provided and I can map back a sass'd and clean'd files to the originating sass. Could you try to modify what you have currently to see if it's fixed? I'd suggest the following...

.pipe(plugins.sourcemaps.write())

... without the pathing resolution passed. I could be way off, but I suspect it's at least worth trying! Thanks for bringing this to my attention. Also, if the issue persists, if you can create a sample replication repo with just a few files which illustrates the issue with your desired result I'll be able to get to the bottom of this much faster.

from gulp-clean-css.

I actually tried that fix as well, but it doesn't seem to help. I'll create a repo that reproduces the issue for you. Thanks for the quick response!

from gulp-clean-css.

cool keep me posted 😄

from gulp-clean-css.

Here's a proof of concept. Instructions in the README.

https://github.com/EAnushan/gulp-clean-css-issue-21

I've pushed a 2.1.1 branch that uses gulp-clean-css version 2.1.1 and doesn't have the same issue.

from gulp-clean-css.

hey guys I committed a possible fix here 06c1706. Could someone please clone this commit down, install, and verify? Probably a npm pack => install tarball would be the best bet. Didn't want to publish this quite yet if not fixed. Thanks

from gulp-clean-css.

Confirmed your last commit fixes the issue. I've also removed the sourceRoot hack you mentioned in #21 (comment). Doesn't look like the hack is necessary anymore =)

from gulp-clean-css.

awesome, 2.3.0 pup'd

from gulp-clean-css.

Thank you!

from gulp-clean-css.