Git Product home page Git Product logo

Comments (11)

GrahamDumpleton avatar GrahamDumpleton commented on July 19, 2024

FWIW, I integrated tini into my Docker base images and thus my S2I builders already. :-)

I pull various source packages and compile from source code so don't have an issue with that, but if you have the restriction of only being able to use official packages that is likely going to be a problem unless there is something equivalent in package repositories already.

from s2i-python-container.

bparees avatar bparees commented on July 19, 2024

@soltysh what's the likelihood that iPython gets fixed? this doesn't sound like a complexity we want to add to our images by default (and we'd need an rpm package of tini, if one doesn't exist, so we'd probably need the SCL team to adopt it)

from s2i-python-container.

GrahamDumpleton avatar GrahamDumpleton commented on July 19, 2024

Reality is that no one would use the Red Hat S2I images if they want to build a Docker image for IPython. So is not a big deal.

from s2i-python-container.

soltysh avatar soltysh commented on July 19, 2024

I think @GrahamDumpleton answered that question already.

from s2i-python-container.

bparees avatar bparees commented on July 19, 2024

Given that, is there a compelling reason to keep this open?

from s2i-python-container.

soltysh avatar soltysh commented on July 19, 2024

I think we can close it. It'll be kept here for reference for other folks struggling with similar problems.

from s2i-python-container.

bparees avatar bparees commented on July 19, 2024

Thanks @soltysh

from s2i-python-container.

soltysh avatar soltysh commented on July 19, 2024

Thank @GrahamDumpleton he pointed me to that problem 😄

from s2i-python-container.

GrahamDumpleton avatar GrahamDumpleton commented on July 19, 2024

I should have clarified that although no one will use this image for IPython, they will use the Tornado WSGI server and Tornado ASYNC server, Waitress WSGI server, plus others such as the Python standard library HTTP server. None of these will handle properly the pid 1 zombie reading and so eventually will crap out due to memory usage issues, or confusion due to reparenting of processes (as is case for IPython). Basically, if anyone supplies their own app.py and overrides gunicorn there is a good chance they will have problems.

I will be posting a blog post about the issue as part of my series on porting IPython to Docker/OpenShift, highlighting how these other commonly used Python web servers can fail.

from s2i-python-container.

soltysh avatar soltysh commented on July 19, 2024

@GrahamDumpleton that sounds perfect, can you please post a link to it in this issue?

from s2i-python-container.

GrahamDumpleton avatar GrahamDumpleton commented on July 19, 2024

http://blog.dscpl.com.au/2015/12/issues-with-running-as-pid-1-in-docker.html

from s2i-python-container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.