Review addition of libjpeg-turbo and libjpeg-turbo-devel about s2i-python-container HOT 8 CLOSED

i'm ok with the 3mb size increase, assuming we can satisfy the other questions.

and yes, definitely should be done in 3.3 and 3.4 as well (assuming we keep it). If we can't justify it in those, then it probably doesn't belong in 2.7 either (unless it's been supplanted by a different library used by python3.3/3.4 apps).

from s2i-python-container.

We don't know yet the original use case, but I was extrapolating that for whatever uses some libjpeg in Python, there'd be a similar "need" in Perl, Ruby, PHP, etc...

Looking at the existing yum packages we install at the sti-python level, those are only Python related (like pip), and httpd is the only exception to that so far.

from s2i-python-container.

@donnydavis can you weigh in here on what your use cases were? we're having trouble justifying keeping the jpeg libs in the common image w/o your help.

from s2i-python-container.

at this point i'm inclined to just close this. we'll leave the library in python2.7 but not add it to the other versions. if a request comes to add it to 3.3 or 3.4 we can revisit this discussion about where it belongs, whether it belongs, etc.

any objections @rhcarvalho ?

from s2i-python-container.

@bparees it will stand out when diff'ing the multiple image versions, but I'm okay with whatever decision you make.

from s2i-python-container.

yeah, minor annoyance, i think we can live with it.

from s2i-python-container.

This should be closed, pillow will now build. Sorry for the delays in getting back to you

from s2i-python-container.

This should be closed, pillow will now build. Sorry for the delays in getting back to you

Do you mean that the libs are not needed?

from s2i-python-container.