Git Product home page Git Product logo

Comments (10)

wdm0006 avatar wdm0006 commented on August 15, 2024

Yeah, that makes sense. In get_dummies in one_hot we build up the encoded columns based on what is in the passed in X, but really ought to get the categories from the pre-trained OrdinalEncoder that got built in fit. I think that would solve this issue.

Is the assumption that all categories you want to encode are present in the dataset you pass to fit reasonable?

from category_encoders.

justkunz avatar justkunz commented on August 15, 2024

Yes, @wdm0006 your assumption is correct, all categories to encode should be passed in the dataset to fit.

from category_encoders.

wdm0006 avatar wdm0006 commented on August 15, 2024

Are you interested in working on a PR @justkunz? If not I'll try to work on this soon.

from category_encoders.

justkunz avatar justkunz commented on August 15, 2024

@wdm0006 I can get a quick PR up.

from category_encoders.

wdm0006 avatar wdm0006 commented on August 15, 2024

Fixed by #20

from category_encoders.

wdm0006 avatar wdm0006 commented on August 15, 2024

Will do a new release soon, would like to try to fix #18 beforehand though if possible.

from category_encoders.

justkunz avatar justkunz commented on August 15, 2024

@wdm0006 what's the status of the 1.2.4 release?

from category_encoders.

wdm0006 avatar wdm0006 commented on August 15, 2024

I need to do a docs update with some of the recent PRs, but will try to get it out this week.

from category_encoders.

wdm0006 avatar wdm0006 commented on August 15, 2024

@justkunz, just released it.

from category_encoders.

justkunz avatar justkunz commented on August 15, 2024

Thanks @wdm0006!

from category_encoders.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.