Comments (5)
Thanks for the note, I was unaware of this.
from scikit-fmm.
Hi and thanks for getting in touch. This seems to be related to this issue:
scikit-image/scikit-image#4369
and as far as I understand it has been fixed by the NumPy developers. Can you give it a try? I do not have and OS X system at the moment to confirm the fix.
from scikit-fmm.
Hi,
Thanks a lot for finding this out :) will give it a try today and let you know
from scikit-fmm.
So far it doesn't work, but I think it makes sense as it will not be available until they release a patch (probably 1.18.1)... hopefully they will do it soon, i will keep an eye on the issue you mentioned and associated PR.
Along similar lines, I also noticed that you only release wheels for Windows on PyPy. When I build from linux or os x (either locally or on a CI machine) the following error arises - I tracked it back and it actually happened also with older versions of numpy. Basically as no wheels are present for those OS, the source is downloaded and wheels are built locally, but since you use numpy.distutils.misc_util
in your build process an error is returned ModuleNotFoundError: No module named 'numpy'
.
2020-01-03T11:29:14.8508020Z Collecting scikit-fmm
2020-01-03T11:29:14.8611780Z Downloading https://files.pythonhosted.org/packages/9a/a5/2bacbdbbde95598fdc36ded7968a2e590f51fcfcd81a68e5c783db131d80/scikit-fmm-2019.1.30.tar.gz (418kB)
...
Building wheels for collected packages: scikit-fmm, sphinx-gallery, numpydoc, backcall, pandocfilters, pyrsistent
2020-01-03T11:29:26.3745000Z Building wheel for scikit-fmm (setup.py): started
2020-01-03T11:29:26.5725920Z Building wheel for scikit-fmm (setup.py): finished with status 'error'
2020-01-03T11:29:26.5728410Z ERROR: Command errored out with exit status 1:
2020-01-03T11:29:26.5731210Z command: /Users/runner/hostedtoolcache/Python/3.7.5/x64/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-install-dlkjnam8/scikit-fmm/setup.py'"'"'; __file__='"'"'/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-install-dlkjnam8/scikit-fmm/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-wheel-b2ksr9ft --python-tag cp37
2020-01-03T11:29:26.5733510Z cwd: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-install-dlkjnam8/scikit-fmm/
2020-01-03T11:29:26.5734200Z Complete output (7 lines):
2020-01-03T11:29:26.5734560Z Traceback (most recent call last):
2020-01-03T11:29:26.5735210Z File "<string>", line 1, in <module>
2020-01-03T11:29:26.5736500Z File "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-install-dlkjnam8/scikit-fmm/setup.py", line 121, in <module>
2020-01-03T11:29:26.5737100Z setup_package()
2020-01-03T11:29:26.5739220Z File "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-install-dlkjnam8/scikit-fmm/setup.py", line 115, in setup_package
2020-01-03T11:29:26.5739790Z from numpy.distutils.core import setup
2020-01-03T11:29:26.5740860Z ModuleNotFoundError: No module named 'numpy'
2020-01-03T11:29:26.5742050Z ----------------------------------------
2020-01-03T11:29:26.5743100Z ERROR: Failed building wheel for scikit-fmm
2020-01-03T11:29:26.5744290Z Running setup.py clean for scikit-fmm
After it automatically tries to rebuild from setup.py install and it succeeds in Unix (and OSX until the latest numpy):
2020-01-03T11:29:27.0236733Z Running setup.py install for scikit-fmm: started
2020-01-03T11:29:36.0328614Z Running setup.py install for scikit-fmm: finished with status 'done'
I tried to force numpy to be installed first, running the following sequence of commands:
python -m pip install --upgrade pip setuptools wheel django
pip install numpy
pip install -r requirements-dev.txt
pip install .
but I get the same error. You should be able to see the log here (either linux or OS X build)
https://dev.azure.com/MRAVA/PyLops/_build/results?buildId=299&view=results
I am not sure this is a big issue as things work fine anyways but I thought about mentioning it just in case you were not aware of it.
from scikit-fmm.
I can confirm that the main problem is now solved, when using numpy 1.18.1 scikit-fmm builds successfully on OS X :)
from scikit-fmm.
Related Issues (20)
- Pip install broken on CIs HOT 4
- about cfmm HOT 1
- ValueError: the array phi contains no zero contour (no zero level set) HOT 1
- cannot import skfmm due to arm64 incompatibility? HOT 1
- Support for python 3.11 HOT 2
- Installation went well, but unable to import HOT 2
- Marching issue in a skeleton HOT 2
- numpy.distutils is no longer available in Python 3.12 HOT 26
- Inaccurate travel paths HOT 2
- Add a less formal introduction of FMM and what it can be used for in the README HOT 1
- error: Multiple top-level packages discovered in a flat-layout: ['skfmm', 'profile']. HOT 5
- Negative curvature of signed distance HOT 9
- a relevant way to cite scikit-fmm
- [Enhancement] Release GIL HOT 3
- Exact representation of contour HOT 13
- Incompatible to numpy 2.0 - numpy removed numpy/noprefix.h HOT 6
- pip instal scikit-fmm error HOT 1
- DEPENDENCY - Update code to use numpy 2.0 HOT 7
- Provide Wheels for scikit-fmm HOT 23
- WARNING: Failed to activate VS environment: Could not find C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scikit-fmm.