NEP-18 not working about autocorr HOT 4 OPEN

I'm late to the party here, just noticed this. The way to handle array creation is use np.*_like functions, as in

numpy.empty_like(some_input_whose_type_will_be_imitated, dtype=..., shape=...)

In the past, the *_like functions did not allow users to customize the shape because the whole point was to return array of the same shape. Now, they may be used to return an array of the same type but, optionally, a different shape or internal dtype. This was a added in a recent release of numpy; the PR to add it to dask is not yet merged as of this writing: dask/dask#6064

from autocorr.

can we walk back up the class / module tree of the input to sort out what version of empty to call?

from autocorr.

Looks like we need to rely on __module__? Not really a fan of it...

>>> import inspect
>>>
>>> import cupy as cp
>>> a = cp.empty(10)
>>> type(a).__module__
'cupy.core.core'
>>> inspect.getmodule(a) is None  # useless
True
>>>
>>> import numpy as np
>>> b = np.empty(10)
>>> type(b).__module__
'numpy'
>>> inspect.getmodule(b) is None  # useless
True

from autocorr.

For CuPy's uninformative __module__, just raised an issue: cupy/cupy#3266. Not sure whether other libraries are compliant on this aspect or not.

from autocorr.