Git Product home page Git Product logo

Comments (7)

schollz avatar schollz commented on August 15, 2024

Is it possible that the filename has some unprintable characters?

from croc.

ErwinLubbers avatar ErwinLubbers commented on August 15, 2024

The only "strange" thing about the filename is that is starts with a underscore.

from croc.

schollz avatar schollz commented on August 15, 2024

okay, something is weird then because I added the filename to the tests of "ValidFilename" , see 05da500

but it is not getting flagged at all, see https://github.com/schollz/croc/actions/runs/9680288293/job/26708096028

this is the ValidName routine: https://github.com/schollz/croc/blob/main/src/utils/utils.go#L572-L590

my only conclusion then is that your file has invisible characters?

from croc.

ErwinLubbers avatar ErwinLubbers commented on August 15, 2024

I did change:

return true, fmt.Errorf("invalid filename detected: '%s'", fi.Name)

to:

return true, fmt.Errorf("invalid filename detected: '%s'", path.Join(c.FilesToTransfer[i].FolderRemote, fi.Name))

because there are 10.326 files that need to be transferred with the name _index_slash_ssl.html. And then it seems that maybe a minus sign at the end of a path is invalid:

www.kringen.nl/wp-content/cache/page_enhanced/www.kringen.nl/jan-valkier-ontvangt-/_index_slash_ssl.html

from croc.

schollz avatar schollz commented on August 15, 2024

That path as it is pasted in Github is not a problem for the file name....something is still missing.

I did something similar which will give more information still: 3e804a4

If you can build from source and try this version of croc, I would be greatly appreciative. This version should print out exactly the character that is a problem.

from croc.

ErwinLubbers avatar ErwinLubbers commented on August 15, 2024

That showed the wrong character (U+65279). Thanks for your help

from croc.

schollz avatar schollz commented on August 15, 2024

Cool thanks!!

from croc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.