the current version of json-c doesn't define 'TRUE' in json_object.h any longer. about rt-app HOT 9 CLOSED

Which repo/branch/version are you using?

from rt-app.

i was using the latest master of both rt-app and json-c, both from github (scheduler-tools/rt-app, json-c/json-c)

from rt-app.

Mmm. I'd say that it's safer/saner to use latest release of json-c which doesn't have this problem.
I'd propose we fix after (and if) json-c decides to make that move.
Maybe we should mention this in tutorial.txt though.. or maybe we could add json-c as a git submodule and enforce its version/head commit?

from rt-app.

somewhat related, shouldn't the tutorial's build section be split off into an INSTALL file?

it's not up to me to decide, but the submodule version sounds like a proper way of doing this. might prevent other issues from creeping up as well.

but: why is json-c treated magically? there are many projects that say they need foo-dev and people are normally happy to install the distro's package. there isn't really any requirement on a particular version of json-c in terms of functionality, or is there?

preemptively, the workaround (#define TRUE 1) seems still useful (because it's going to be someone else who's distro will be switching to a newer version of json-c), but maybe it's cleaner to s/TRUE/true/g?

from rt-app.

somewhat related, shouldn't the tutorial's build section be split off into an INSTALL file?

We should indeed.

from rt-app.

why is json-c treated magically?

Just because you might need to statically compile it for your sys/arch?

from rt-app.

the workaround (#define TRUE 1) seems still useful

Guess it makes sense yes. Would you mind submitting a PR?

from rt-app.

i added a comment to the PR that pino-kim beat me to: #63
but can also create another one. will create one for INSTALL later.

from rt-app.

@pino-kim/@jlelli fixed it with #65, works for me, thus closing.

from rt-app.