Layout broken when upgrading from 1.2.3 to 1.3.0 about floatingpanel HOT 15 CLOSED

Also the use of a search controller in the navigation bar also seems to throw off the bottom safe area on the floating panel

from floatingpanel.

I'm sorry for your inconvenience. I will fix it as soon as possible and release v1.3.1.

from floatingpanel.

If you have a time, could you please try improve-samples-app branch?

from floatingpanel.

Ok I have tried the improve-samples-app branch and the issue is still present. Another issue that is affecting both improve-samples-app branch and the master 1.3 branch is that if the parent VC has a search controller in the navigation bar, the bottom safe area of the floating panel is pushed below the screen. When I removed the search controller, only the top part of the floating panel, the height of the handle, shows up on the bottom of the screen but only when my large title navigation bar shrinks to the regular small sized one. You can see this in the following screen shot...

from floatingpanel.

I found a suspicious problem of Auto Layout constraints to SafeArea.Top with a translucent navigation bar.

I struggled with it over a day but I can't have figured out the reason yet... However I found the issue can be resolved by replacing the constraints to SafeArea.Top with ones to Superview.Top. I think the change doesn't matter from characteristics of the UI, it's not best though.

I updated improve-samples-app branch(NOTE: forced update) and then I added preconditionFailure for SafeArea.Top with with a translucent navigation bar.
https://github.com/SCENEE/FloatingPanel/pull/86/files#diff-9010b8645e15999bbcccd463b07b21bfR264

What do you think of it?

EDIT

I fixed the suspicious problem. I updated improve-samples-app branch(NOTE: forced update).
But I haven't yet investigate the problem you reported with a navigation bar including search bar. I will try to reproduce it.

from floatingpanel.

Sorry I've just been on Christmas holidays, so far I have tried the new update to the improve-samples-app but the issue still exists. But after reconsidering the workflow of my app, I'm gonna put the calculator somewhere else without the floating panel. But I will use the floating panel for another idea I've got. Really great framework even though there's minor hiccups. Keep up the awesome work.

from floatingpanel.

I'm so sorry that I couldn't help you and your beautiful app. I've released v1.3.1 today. I hope this issue would be fixed. I really appreciate your help. I always welcome any contributions. Thank you so much!

from floatingpanel.

➕1️⃣ I can reproduce this issue on the latest version, downgrading to 1.2.3 via CocaPods and the issue is gone

from floatingpanel.

This issue might be fixed by PR #168. It will be released in v1.4.1.

from floatingpanel.

I've released v1.4.1 today. Could you please try it? Thanks.

from floatingpanel.

Still there I'm afraid, attached a zip with two videos, one taken using 1.2.3 & one using 1.5.0
FloatingPanel.zip

from floatingpanel.

Thanks, @AlexLamond. I understand your issue now. I will investigate it.

from floatingpanel.

@AlexLamond,
The view hierarchy was changed between 1.2.3 to 1.3.0 so that the issue happens. The change might affect the safeAreaInsets update by the iOS layout system on the FloatingPanelController in your app.

By the way, you're able to resolve this issue with contentInsetAdjustmentBehavior = never and manually update a content inset of your content view.

It's difficult for me to fix this issue as long as I can't repro this issue because I cannot observe iOS system behavior. If you give me a sample code(it's ok to send it to me by email), that is much helpful.

from floatingpanel.

v1.6.3 has a bugfix for the SafeArea. Additionally change-safe-area-reference branch has a possible-fix for this safe area issue. I'm so glad if you try both of them.

from floatingpanel.

If anyone could reproduce this issue on v2, please reopen this.

from floatingpanel.