Segues from floating panel about floatingpanel HOT 10 CLOSED

I've implemented the new commit and it no longer crashes when loading the initial view controller. However the segue performs just as it did while using v1.1 of the floating panel.

I am very sorry to keep bothering you, I just don't know what I am doing wrong. Would it be possible to send you my project? If not, I completely understand. And I really do appreciate all the time you've already committed to this.

from floatingpanel.

Thank you for your report! You're right and this library has a problem on this case.
I'm trying to fix it now. Please wait for a little while longer.

from floatingpanel.

@jaytrisw,

Could you try 'fix-show-segue-problem' branch referred by PR #21 ?

FloatingPanelController.show(_:sender) causes this issue. After I changed the implementation at
0f60068 commit to keep the backward compatibility for v1.1.0, I think it's better to replace this method with FloatingPanelController.set(contentViewController:). The migration is easy through 2-time fixes of build errors.

What do you think of the change?

Thank you for your cooperation.

from floatingpanel.

I am getting a crash when I try to load the floating panel.

I'm sure that I've just done something wrong. Is the only code change that I need to make:

fpc.set(contentViewController: searchVC)

from floatingpanel.

Also, I tried adding another view controller to the map sample project and performing a segue using performSegue(withIdentifier: "pushVC", sender: nil) it still adds the new view controller in the floating panel.

from floatingpanel.

Well, it should works only after you change your code like here

And I expect performSegue(withIdentifier:sender:) works like here.

Could you find the difference between your codes and the above links?

from floatingpanel.

I am sorry, I am very new to iOS development. I'm just not understanding the sample project.

from floatingpanel.

I'm sorry too to confuse you. I've updated 'fix-show-segue-problem' branch. Now I hope it would work your 'pushVC' segue in your content view controller on the branch. You don't need to change from fpc.show(searchVC sender:nil) to fpc.set(contentViewController: searchVC).

from floatingpanel.

Good news! Of course, could you send a email to me to share a dropbox link of your project ? My email address is in README.

from floatingpanel.

Sent, thank you!

from floatingpanel.