Inconsistent `extends` alignment with `align.preset = more` about scalafmt HOT 8 CLOSED

@NColey if your example is correct, then the problem is case class A must be followed by a list of parameters (otherwise it should be a case object). when i tried class A instead, it aligned correctly.

from scalafmt.

@kitbellew I'm sorry that was a typo on my end. The issue I'm seeing is specifically with case objects. I have fixed the example.

from scalafmt.

@NColey weird. case object works for me. specifically, i added this:

<<< ONLY #3762
object a {
  case object A extends Something
  case object AAA extends Something
}
>>>
object a {
  case object A   extends Something
  case object AAA extends Something
}

to the end of DefaultWithAlign.stat file and ran FormatTests.

from scalafmt.

are you sure that your example is not just similar to what you specified but in reality is a lot longer? scalafmt no longer allows alignment to overflow maxColumn unless explicitly configured to do this.

from scalafmt.

@kitbellew so I created a super minimal reproduction of the issue here if that helps. If you clone that down and run scalafmt with the latest CLI it will remove the alignment from extends in alignment.scala even though it was previously aligned (or at least it does for me with scalafmt 3.7.17 as the cli version).

Re maxColumn -- when I bumped the version from 2.3.2 to 3.7.17 I responded to anything that was flagged as an error (i.e settings being renamed or removed) and that one wasn't flagged as an issue so I left it as is.

That said, if you look at the repo where I have reproduced this issue you can see I tried it with and without adjustments to maxColumn and it still un-aligns case objects on the extends portion. Totally open to something else in that config file being the issue though I have turned a number of settings on and off and can't seem to preserve the alignment that was there in 2.3.2.

from scalafmt.

@NColey extends is no longer owned by Defn.Object but by the Template field within it. so if you remove all your align { ... } customizations, it formats correctly.

from scalafmt.

you should use AST Explorer linked from https://scalameta.org/scalafmt/docs/configuration.html#aligntokens, it will show you tokens and trees.

from scalafmt.

OH! Oh wow thank you, that totally was the issue. I appreciate the AST Explorer suggestion as well, thank you so much 🙏 . I'll close this issue now but appreciate your help here.

from scalafmt.