Symbols hierarchy about metals HOT 7 CLOSED

Wow, that would be super cool to support! scala.meta.Symbol is an ADT with cases

• Symbol.None
• Symbol.Local, these are definitions inside local blocks, can't be globally referenced
• Symbol.Global, this one is the one you're looking for, you can create hierarchical data structures from it with .owner/.signature
• Symbol.Multi

Source https://github.com/scalameta/scalameta/blob/23de1ca839e53ad6387981bd7cced35122a2cf76/langmeta/shared/src/main/scala/org/langmeta/semanticdb/Symbol.scala#L24

To get the SymbolKind of a symbol you need the Denotation from https://github.com/scalameta/language-server/blob/04ff21002da48ea293dbed9ad99efbb366198d0e/metaserver/src/main/scala/scala/meta/languageserver/SymbolIndexer.scala#L23

from metals.

OK. Thanks for the references. I'll submit a PR shortly. Didn't solve it completely, but got something.

from metals.

You probably have to change the signature of SymbolIndexer.documentSymbols to include the Symbol.Global from here

https://github.com/scalameta/language-server/blob/04ff21002da48ea293dbed9ad99efbb366198d0e/metaserver/src/main/scala/scala/meta/languageserver/SymbolIndexer.scala#L36

and then use Symbol.Global.owner.syntax as the container name.

from metals.

Thanks. I actually moved the implementation to SymbolIndexer.documentSymbols and changed its return type to Seq[SymbolInformation]. Is it ok or should I be more conservative with the interface?

from metals.

Symbols's syntax is definitely not what we want here because name is what is shown directly in the GUI, and containerName has to refer to the same name parent symbol has.

from metals.

Fixed by #34 @laughedelic ?

from metals.

Yes, let's close it. The nested hierarchy issue is resolved by #34. It still needs improvements, but it will be addressed in another PR.

from metals.