Empty tooltips on hover about metals HOT 3 CLOSED

Two things:

• the fact that an empty tooltip (as opposed to no tooltip) is displayed when no hover info is returned by the server is up to the client (vscode in this case). There's a related discussion here: microsoft/language-server-protocol#261

• the fact that those info are missing is a limitation of the semanticdb information we have. I'm experimenting with a different approach in #21

from metals.

Thanks for the link to discussion in the LSP repo. But the problem here is that the response is neither [] nor "", it's [""]:

"contents":[{"language":"scala","value":""}]

And it corresponds to this line:

https://github.com/laughedelic/language-server/blob/ba7d552904b08601c86fd42b5ea1160c35d8636f/metaserver/src/main/scala/scala/meta/languageserver/ScalametaLanguageServer.scala#L257

So I added a check for non-empty denotation.signature and it seems to work well, both in VS Code and in Atom: [] is interpreted as no hover information and the tooltip is not shown 👌

from metals.

Fixed by #21

from metals.