Git Product home page Git Product logo

Comments (12)

domizei385 avatar domizei385 commented on June 20, 2024 2

@bpossolo You are right. There are more changes than necessary. My initial goal was to unblock a collegue. I have not tested this on eclipse myself and as I mentioned there is one test failing. Nevertheless I created the PR, but I am fairly certain that no one will care to merge it unless this test is fixed.
Generally this may run into issues when the internal api change, but I would worry about that once the time comes. Doing such a change exceeds my allotted time.

As for the underlying issue: sbt changed to use VirtualFileRef instead of File. The plugin tries match source files to their generated artifacts (as part of the sbt execution). My fix is to map the source files to VirtualFileRef, than match those against the Analysis.relations, followed by copying the generated artifact to the proper folder.

from sbt-eclipse.

domizei385 avatar domizei385 commented on June 20, 2024

I created a fix in my fork at https://github.com/domizei385/sbteclipse (Branch sbt_1.4).
There is one test still failing, but it is not relevant for my use case.

from sbt-eclipse.

bpossolo avatar bpossolo commented on June 20, 2024

seeing this with sbt 1.4.7 + sbteclipse 5.2.4

from sbt-eclipse.

mkurz avatar mkurz commented on June 20, 2024

@domizei385 How about creating a pull request with your fixes?

from sbt-eclipse.

bpossolo avatar bpossolo commented on June 20, 2024

@domizei385 your branch has a lot of changes that seem like they might be unnecessary to get the plugin to work.
if you don't have time to submit a PR, could you describe what the main issue is?
It looks like the issue is caused by a reference to an sbt internal method which no longer exists.
I noticed in your branch you're still using sbt.internal.inc.Analysis
is it safe to reference sbt.internal.* components or does that open it up for failure again in the future the next time the internal api changes?

from sbt-eclipse.

ProChirathF avatar ProChirathF commented on June 20, 2024

Any plans of a fix for this issue? We would like to use sbt 1.5.0 with PlayFramework v2.8.8

from sbt-eclipse.

mkurz avatar mkurz commented on June 20, 2024

A couple of weeks ago I had a look what the problem is and I think back then I found out what's going on. Maybe I find them the next days to provide a pull request with a fix (but I am busy currently)

from sbt-eclipse.

ProChirathF avatar ProChirathF commented on June 20, 2024

Thanks, looking forward to a fix.

from sbt-eclipse.

prosasankad avatar prosasankad commented on June 20, 2024

Hi,
Any progress on this issue ? We need to upgrade to newer sbt version due to log4j vulnerability but this issue stops us from upgrading

Thanks

from sbt-eclipse.

mkurz avatar mkurz commented on June 20, 2024

No time to work on it yet, but it's on my radar.

from sbt-eclipse.

mkurz avatar mkurz commented on June 20, 2024

We are very close to a sbt-eclipse 6.0.0 release, finally with support for sbt 1.4.0+ (I merged #402 already). Now I am waiting for access to push the artifacts to maven central: https://issues.sonatype.org/browse/OSSRH-77819?focusedCommentId=1202733&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1202733

I hope that happens within the next 24 hours.

from sbt-eclipse.

mkurz avatar mkurz commented on June 20, 2024

It took ages, but finally, after 5 years, I just released a new sbt-eclipse version: https://github.com/sbt/sbt-eclipse/releases/tag/6.0.0 with support for newer (1.4+) sbt versions.
Be aware that the groupId and artifact name changed, see the release notes.
Also, from now on, releases are hosted on Maven Central, so you don't need to configure any resolvers: https://repo1.maven.org/maven2/com/github/sbt/sbt-eclipse_2.12_1.0/6.0.0/

from sbt-eclipse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.