Comments (12)
@bpossolo You are right. There are more changes than necessary. My initial goal was to unblock a collegue. I have not tested this on eclipse myself and as I mentioned there is one test failing. Nevertheless I created the PR, but I am fairly certain that no one will care to merge it unless this test is fixed.
Generally this may run into issues when the internal api change, but I would worry about that once the time comes. Doing such a change exceeds my allotted time.
As for the underlying issue: sbt changed to use VirtualFileRef instead of File. The plugin tries match source files to their generated artifacts (as part of the sbt execution). My fix is to map the source files to VirtualFileRef, than match those against the Analysis.relations, followed by copying the generated artifact to the proper folder.
from sbt-eclipse.
I created a fix in my fork at https://github.com/domizei385/sbteclipse (Branch sbt_1.4).
There is one test still failing, but it is not relevant for my use case.
from sbt-eclipse.
seeing this with sbt 1.4.7 + sbteclipse 5.2.4
from sbt-eclipse.
@domizei385 How about creating a pull request with your fixes?
from sbt-eclipse.
@domizei385 your branch has a lot of changes that seem like they might be unnecessary to get the plugin to work.
if you don't have time to submit a PR, could you describe what the main issue is?
It looks like the issue is caused by a reference to an sbt internal method which no longer exists.
I noticed in your branch you're still using sbt.internal.inc.Analysis
is it safe to reference sbt.internal.*
components or does that open it up for failure again in the future the next time the internal api changes?
from sbt-eclipse.
Any plans of a fix for this issue? We would like to use sbt 1.5.0 with PlayFramework v2.8.8
from sbt-eclipse.
A couple of weeks ago I had a look what the problem is and I think back then I found out what's going on. Maybe I find them the next days to provide a pull request with a fix (but I am busy currently)
from sbt-eclipse.
Thanks, looking forward to a fix.
from sbt-eclipse.
Hi,
Any progress on this issue ? We need to upgrade to newer sbt version due to log4j vulnerability but this issue stops us from upgrading
Thanks
from sbt-eclipse.
No time to work on it yet, but it's on my radar.
from sbt-eclipse.
We are very close to a sbt-eclipse 6.0.0 release, finally with support for sbt 1.4.0+ (I merged #402 already). Now I am waiting for access to push the artifacts to maven central: https://issues.sonatype.org/browse/OSSRH-77819?focusedCommentId=1202733&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1202733
I hope that happens within the next 24 hours.
from sbt-eclipse.
It took ages, but finally, after 5 years, I just released a new sbt-eclipse version: https://github.com/sbt/sbt-eclipse/releases/tag/6.0.0 with support for newer (1.4+) sbt versions.
Be aware that the groupId and artifact name changed, see the release notes.
Also, from now on, releases are hosted on Maven Central, so you don't need to configure any resolvers: https://repo1.maven.org/maven2/com/github/sbt/sbt-eclipse_2.12_1.0/6.0.0/
from sbt-eclipse.
Related Issues (20)
- Doesn't see managedSources unless explicitly invoked
- feature request: need a way to specify an alternative default build files directory HOT 15
- Support for multi-project build HOT 1
- relocate from typesafehub org to Lightbend org HOT 4
- documentation infinite loop HOT 1
- Feature: consistent project names
- sbteclipse
- sbteclipse installation i do not understand HOT 1
- sbteclipse plugin doesn't download. HOT 1
- sbteclipse 5.2.5? HOT 1
- [error] a required artifact is not listed by module descriptor: *#*!*.* HOT 2
- Feature Request: allow for custom `createLinkName` function
- Missing entry's in ".classpath" since Java-Secure-Update HOT 3
- Support for Java 9 and above? HOT 3
- Scala Compiler Cannot Apply Installation for Project Settings
- Add support for Java Execution Environments 9, 10, 11, 12, 13 HOT 1
- Missing Scala lib in .classpath HOT 2
- Travis CI is dropped HOT 1
- Getting unresolved dependency for sbteclipse-plugin in sbt 1.2.8 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-eclipse.