Git Product home page Git Product logo

Comments (4)

etiennedeg avatar etiennedeg commented on June 2, 2024

The error is here : the edge is added only if state.low[v] > state.depth[w], whereas it should be always added to the stack. I can make a PR, but I have an interrogation: Why do we return the biconnected components by their edges? As the subgraphs are induced, this is more easily defined by the vertices. Is there a good reason to do that, or would it be too breaking to change this behavior?

from lightgraphs.jl.

lindapamg avatar lindapamg commented on June 2, 2024

Because I want to gain biconnected_components with edges to remove some unwanted edges. So , How can we solve this problem(error)?

from lightgraphs.jl.

lindapamg avatar lindapamg commented on June 2, 2024

The error is here : the edge is added only if state.low[v] > state.depth[w], whereas it should be always added to the stack. I can make a PR, but I have an interrogation: Why do we return the biconnected components by their edges? As the subgraphs are induced, this is more easily defined by the vertices. Is there a good reason to do that, or would it be too breaking to change this behavior?

Thank you for you reply this problem.

from lightgraphs.jl.

etiennedeg avatar etiennedeg commented on June 2, 2024

My response is mainly intended to contributors of LightGraphs, and does not actually gives you an easy workaround for the problem. It seems that at the moment, the committers are not very active, but this is probably a consequence of summer vacations. So I can't exactly tell you when this will be fixed. If you need a workaround quickly, you can either modify directly the package (following the fix I described), or copy the biconnected_components in your code and override it with the fix.

from lightgraphs.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.