Git Product home page Git Product logo

Comments (3)

SBoudrias avatar SBoudrias commented on August 18, 2024

That's a good question... The stream need to be flushed but you don't use the covered files objects in this case.

I'd run the question around the community, maybe there should be a gulp-flush plugin that just consume files but don't pass them through.

from gulp-istanbul.

SBoudrias avatar SBoudrias commented on August 18, 2024

Ok, so I guess the core issue it is a design error on this plugin part.

We pass through the instrumented files to allow coverage report from other environment than node. This mean that we build up the back pressure and it is never released as most user won't add any task after the istanbul stream.

Maybe we should make a config to control pass through:

gulp.src()
  .pipe(istanbul({ passthrough: true })

Or separate the coverage from actually hooking require, meaning the last step is an output step and won't pass through the files.

gulp.src()
  .pipe(istanbul.cover())
  .pipe(istanbul.hookRequire())

from gulp-istanbul.

larsthorup avatar larsthorup commented on August 18, 2024

Thanks, this fixed the issue for me :)

from gulp-istanbul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.