Comments (12)
Yeah, I see what the problem is. SDCAlertView
is presented in its own window, and doesn't currently have any custom rotation behavior, which I think just means "always rotate".
Making the alert view controller have the same rotation behavior as the user window's current view controller wouldn't be too hard. The coordinator would have to figure out rotation behavior from the user window's view controller and apply it to the alert view controller as well.
I probably won't have time to look at this until next weekend, so if feel free to give it a shot if you're feeling adventurous. I can give you a few pointers if you want. Otherwise, I hope I can issue a fix next weekend.
from sdcalertview.
I would love to have a shot at it, but:
- Currently getting an App ready for 1.0 submission to store.
- Doing support for www.typhoonframework.org
In terms of impact, the issue doesn't bother us too much, thought its worth mentioning hence this ticket.
from sdcalertview.
Sure, no problem! I'll get to it eventually, thanks for bringing it up.
from sdcalertview.
from sdcalertview.
Sure, no problem! Glad you like it.
from sdcalertview.
I tried it myself, and I believe this is fixed now. Please let me know if you're still encountering issues!
from sdcalertview.
Great! Verify from :head or from latest in CocoaPods mater repo?
from sdcalertview.
I haven't updated CocoaPods yet, so you'll want to pull the latest from here until CocoaPods is up to date as well.
from sdcalertview.
OK pod 'SDCAlertView', :head
it is then.
from sdcalertview.
Verified here.
from sdcalertview.
Hello, soon a new pod version contains this fix?
from sdcalertview.
Yes, I'll look into updating the CocoaPods version to include this and a number of other fixes soon.
from sdcalertview.
Related Issues (20)
- Swift 4.2 and Xcode 10.1 Compilation Issue HOT 2
- Swift 4.2 and Xcode 10.1 Compilation Issue HOT 2
- Convert to Swift 5 HOT 1
- SPM support HOT 7
- [Question] Exclude view from being dimmed HOT 1
- Error with Catalyst HOT 2
- AttributedTitle of AlertAction does not apply (Color, font, etc...) with ActionSheet
- Example app crash on iPad presenting UIAlertController
- Readme.md images cannot be loaded
- Evaluate support to popover ActionSheet on iPad HOT 3
- ActionSheet custom view vertical alignment
- Open components to inheritance outside SDCAlertView module HOT 4
- Rounded corners are circles instead of squircles
- Different look for dark theme in ios 13 and ios 12 HOT 6
- AlertController with preferredStyle of .actionSheet Does Not Correctly Display attributedTitle or attributedMessage
- Crash on iOS 15 HOT 2
- How to perform height animation on contentView correctly? HOT 1
- Warning when showing AlertView with textfield
- override var supportedInterfaceOrientations: UIInterfaceOrientationMask HOT 1
- Crash on tintColorDidChange HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdcalertview.