Git Product home page Git Product logo

Comments (12)

sberrevoets avatar sberrevoets commented on May 23, 2024

Yeah, I see what the problem is. SDCAlertView is presented in its own window, and doesn't currently have any custom rotation behavior, which I think just means "always rotate".

Making the alert view controller have the same rotation behavior as the user window's current view controller wouldn't be too hard. The coordinator would have to figure out rotation behavior from the user window's view controller and apply it to the alert view controller as well.

I probably won't have time to look at this until next weekend, so if feel free to give it a shot if you're feeling adventurous. I can give you a few pointers if you want. Otherwise, I hope I can issue a fix next weekend.

from sdcalertview.

jasperblues avatar jasperblues commented on May 23, 2024

I would love to have a shot at it, but:

In terms of impact, the issue doesn't bother us too much, thought its worth mentioning hence this ticket.

from sdcalertview.

sberrevoets avatar sberrevoets commented on May 23, 2024

Sure, no problem! I'll get to it eventually, thanks for bringing it up.

from sdcalertview.

jasperblues avatar jasperblues commented on May 23, 2024

👍 Thanks again for a super useful library.

from sdcalertview.

sberrevoets avatar sberrevoets commented on May 23, 2024

Sure, no problem! Glad you like it.

from sdcalertview.

sberrevoets avatar sberrevoets commented on May 23, 2024

I tried it myself, and I believe this is fixed now. Please let me know if you're still encountering issues!

from sdcalertview.

jasperblues avatar jasperblues commented on May 23, 2024

Great! Verify from :head or from latest in CocoaPods mater repo?

from sdcalertview.

sberrevoets avatar sberrevoets commented on May 23, 2024

I haven't updated CocoaPods yet, so you'll want to pull the latest from here until CocoaPods is up to date as well.

from sdcalertview.

jasperblues avatar jasperblues commented on May 23, 2024

OK pod 'SDCAlertView', :head it is then.

from sdcalertview.

jasperblues avatar jasperblues commented on May 23, 2024

Verified here. 👍

from sdcalertview.

marcaudefroy avatar marcaudefroy commented on May 23, 2024

Hello, soon a new pod version contains this fix?

from sdcalertview.

sberrevoets avatar sberrevoets commented on May 23, 2024

Yes, I'll look into updating the CocoaPods version to include this and a number of other fixes soon.

from sdcalertview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.