Comments (6)
I think it would be best to make PHP_CodeSniffer use the generally accepted Posix exit codes: http://tldp.org/LDP/abs/html/exitcodes.html
However, I would be open to adding an option for formatters that decide to go rogue with their exit codes.
from neoformat.
I totally agree with you. I opened issue on PHP_CodeSniffer squizlabs/PHP_CodeSniffer#1359
from neoformat.
They are not interested in fixing it.
How about adding an optional callback function which validates the exit codes?
from neoformat.
An optional callback could be created, but it will require some work since Neoformat currently uses v:shell_error
after calling system()
to check if the command error.
Here is the relevant doc:
v:shell_error
Result of the last shell command. When non-zero, the last
shell command had an error. When zero, there was no problem.
This only works when the shell returns the error code to Vim.
The value -1 is often used when the command could not be
executed. Read-only.
Example:
:!mv foo bar
:if v:shell_error
: echo 'could not rename "foo" to "bar"!'
:endif
from neoformat.
The v:shell_error
does seem to contain the command exit code
:call system("exit 4")
:echo v:shell_error
4
so it should not be too much work.
from neoformat.
See new config variables:
https://github.com/sbdchd/neoformat#config-optional
from neoformat.
Related Issues (20)
- clang-format used when formatter fails in some filetypes
- [Solved] fprettify makes nvim buffer empty HOT 1
- C# clang-format with Microsoft style broken HOT 1
- truncating files HOT 1
- Pyi files
- Clang-format doesn't use the style config file closest to the file's location
- Formatting F# buffer replaces it with error message
- g:neoformat_only_msg_on_error not working correctly
- Topiary support HOT 1
- Monorepo project root determination
- Adding `eslint_d` as valid formatter for another filetype, like "Vue" HOT 3
- .clang-format file is ignored when style is specified to file
- Configuration on neovim use lua HOT 1
- Add dprint as a formatter HOT 2
- Add ruff formatter for Python HOT 3
- Format only changed lines
- clang-format not work
- Please start tagging releases or remove the old tags
- formatters prettierd, eslint_d failed
- Neoformat Laravel pint keeps removing new line
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neoformat.