Git Product home page Git Product logo

Comments (20)

sayanarijit avatar sayanarijit commented on July 2, 2024 1

Before that, someone has to submit and maintain the xplr build on the distro repo. I did give snap a try, but it required significant manual efforts. So I had to discontinue.
https://www.reddit.com/r/Ubuntu/comments/uvwohe/is_anyone_interested_in_maintaining_xplr_in_snap/

https://forum.snapcraft.io/t/request-deletion-of-snap-xplr/30145

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024 1

thereThank you for the detailed explanation, and I appreciate the effort you've put into maintaining the project. I'm interested in contributing to the maintenance and packaging of xplr for Debian-based distributions. I believe it would be beneficial to make it more accessible to a wider audience.

I'll look into what it takes to create and maintain a package for Debian-based systems. If you have any guidance or specific requirements for the process, I'd be happy to collaborate and work on this together. Let's make xplr more easily installable for GNU/Linux users!

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024 1

I'm interested in contributing to the maintenance and packaging of xplr for Debian-based distributions.

Cool. I guess debian/ubuntu wiki or launchpad could provide some useful information.

I wanted to inquire about the status of the unsupported Snap release in our GitHub CI Actions commits. Could you please provide more information on where and when this unsupported release is occurring?

sorry I didn’t get the question. Are you asking why the snap build was failing? If yes, I think it was some security related thing specific to snap. I had to get some permission from the snap team to be able to build xplr. There’s currently no snap support planned by me.

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024 1

Ah got it. This was the final snap file: https://github.com/sayanarijit/xplr/blob/ad2c7ab69561a0e7df3f5c3238305706bf953ca2/snap/snapcraft.yaml

It was removed in 278642c

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024 1

If you can, please feel free to add a CI/CD action for the same.

Sure, may you will probably receive a PULL REQUEST in the next few days

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024 1

It might result in redundant code. But i guess it’s fine because that way changes in one build config won’t impact others. Also it will avoid some complexity of using matrix for different targets.

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024 1

Thanks for the pr btw. I’ll review tomorrow.

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024

Hi, I haven’t seen any. I maintain the github, crates and nixos releases. Others are maintained by community contributors.

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

How we can to build and maintain our package? exactly my question is, can we add it to installation list?

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

I wanted to inquire about the status of the unsupported Snap release in our GitHub CI Actions commits. Could you please provide more information on where and when this unsupported release is occurring?

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

sorry I didn’t get the question. Are you asking why the snap build was failing?

Ah, I see I might not have been clear. My question was more aimed at understanding the specific point in the commit history where support for snap packages was discontinued or if the inclusion of snap build in the CI Actions was intentionally omitted?

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

Hello dear @sayanarijit

again me,
Is it enough to publish on GitHub releases?
Is it also considered for snapcraft repository?

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024

Sorry I don’t understand the questions. Can you pls elaborate?

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

Do you think it's enough to just put the xplr.snap file in GitHub Releases?

something like vercel/hyper
image

Or do you think it is better for the user to be able to install it through the snap install xplr command?

Considering that we have reached almost 50% of the way to publish on GitHub Releases, but they are very strict about publishing on snapcraft.io.

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024

Ah I didn't know we can release snap package on github like this. I never gave it a try. Ofcourse I'm willing to add github release for snap, deb etc. but I don't know how to package and troubleshoot them, so haven't added yet. If you can, please feel free to add a CI/CD action for the same.

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

Hi again, is there manual generation of GitHub Releases or is it built from GitHub Action?
In other words, are you manually creating GitHub releases?

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

Ok, I'm found answer in here:

- name: Releasing assets
uses: softprops/action-gh-release@v1
with:
files: |
target/${{ matrix.target }}/release/xplr-${{ matrix.build }}.tar.gz
target/${{ matrix.target }}/release/xplr-${{ matrix.build }}.sha256
target/${{ matrix.target }}/release/xplr-${{ matrix.build }}.tar.gz.asc
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

What is your opinion about separating all the targets on the .github/workflows/cd.yml as a separate and isolated action file? to make maintenance easily.

for example:

  • macos-release.yml
  • macos-aarch64-release.yml
  • linux-musl-release.yml
  • linux-aarch64-release.yml
  • linux-arm-release.yml
  • cargo-release.yml
  • snapcraft-release.yml

from xplr.

sayanarijit avatar sayanarijit commented on July 2, 2024

Hey, unfortunately, snap build failed with the following error:

Starting Snapcraft 8.0.4
Logging execution to '/home/runner/.local/state/snapcraft/log/snapcraft-20240318-103346.813681.log'
Launching a VM.
launch failed: multipass socket access denied
An error occurred with the instance when trying to launch with 'multipass': returned exit code 2.
Ensure that 'multipass' is setup correctly and try again.
rm: cannot remove './*.snap': No such file or directory

I'll disable the job for this release. Let's try this in next release. Need to test things properly in a docker container.

from xplr.

mikoloism avatar mikoloism commented on July 2, 2024

Hummm, the multipass installed successfully, but have not access to permissions, it need to grant permissions via snap connect multipass:* and installing experimentally multipass_socket

I will fix it and make PR.

from xplr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.