Auto disown when opening in gui about xplr HOT 57 CLOSED

What's your $OPENER? I recently discovered that xdg-open is quite weird sometimes, after I forced it to be an alias to gio open my life became so much better and random bugs just went away. Could it be this case too? 🤔

My solution was to simply create an executable script called ~/.local/bin/xdg-open with the contents below (assuming ~/.local/bin is first in $PATH):

#!/bin/sh

gio open "$@"

Maybe worth a try for you too? Do this, open new terminal, double check that which xdg-open now points to it, and then retry.

from xplr.

I have tried stock i3 and it appears to be broken.

from xplr.

I use arch btw

from xplr.

You can use ctrl-r to reset the screen. Or terminal resize should also work.

from xplr.

@aflyingpumpkin let me know if ^ this works.

from xplr.

@aflyingpumpkin let me know if ^ this works.
This does resolve the buggy visuals open closing a gui. Though I still can't use xplr while a GUI application is open.

from xplr.

Should solve. I can't can test it now because my window manager will autoresize the screen which causes the refresh automatically.

from xplr.

CTRL+R doesn't solve it? Can you pls provide more info like which OS, window manager, terminal are you using?
A gif would be awesome.

from xplr.

My window manager (dwm) also resizes the window upon closing the GUI. But I believe the GUI the process is not completely terminated when the window resizes which causes the buggy visuals. Also, I am locked out of xplr when the gui is open.

from xplr.

Have you tried other terminals?

from xplr.

Just tried in Alacritty and the issue still persists.

from xplr.

Which application are you trying to open?

from xplr.

If I run xdg-open x.doc, it opens in Kate and works fine.

from xplr.

Just FYI this command is being executed.

from xplr.

${OPENER:-open} "${XPLR_FOCUS_PATH:?}" &> /dev/null &

This might solve the issue but need to test it. @aflyingpumpkin can you try overwriting the command?

from xplr.

${OPENER:-open} "${XPLR_FOCUS_PATH:?}" &> /dev/null & disown -h
Fixes my issue though it does cause some text to be displayed on xplr when opening prior to window resize

from xplr.

is the text that appears

from xplr.

And ctrl+r doesn't fix it?

from xplr.

ctrl+r fixes it, and it usually goes away when the application is opened unless I am in fullscreen mode.

from xplr.

Hmm... not sure how to workaround this without a proper testing environment. @aflyingpumpkin if possible, can you pls create a PR?

from xplr.

What is a PR?

from xplr.

A pull request with the fix. No problem, I can do this.

from xplr.

Just found out that the random text was due to me accidentally putting:
OPENER="$(which xdg-open $)"
instead of
OPENER="$(which xdg-open)"

from xplr.

Ah ok.. Unfortunately the disown hack is causing other side effects. After I exit the session, the terminal session is messed up if there are disowned jobs. I think we need to investigate more into this.

from xplr.

Nope, that was my fault. I used disown incorrectly and didn't exit the terminal.

from xplr.

I found an issue with the disown hack. If xplr is still open and the terminal is terminated the gui will also be terminated.

from xplr.

Weird... Not in my WM...

from xplr.

I'll setup a test VM with dwm when I get some time. Meanwhile, @aflyingpumpkin you can experiment with different command combinations and let me know if you find anything that works.

from xplr.

Although if it's too hacky, we'll probably need to report the issue to DWM maintainers.

from xplr.

I got a ping on the (now closed) PR, to be honest I can't reproduce the issue on latest main (kitty, sway, arch) - i can open multiple files using gx, I can then close xplr, close terminal, and all gui app will remain and will function properly 🤷‍♂️

from xplr.

What I have been doing. I noticed that disown -h appears to not be needed ${OPENER:-open} "${XPLR_FOCUS_PATH:?}" &> /dev/null & does the same thing.

Also, I just booted up i3 and the issue is still persisting.

from xplr.

I am using xdg-open, after doing a force alias the bug still persists.

from xplr.

I think it may be a problem with disown. Currently only having the & symbol is needed, and disown -h should block the termination signal from doing anything.

from xplr.

@aflyingpumpkin I was using plain disown, not disown -h.

from xplr.

Try this: https://github.com/sayanarijit/xplr/pull/109/files

from xplr.

I saw, even when I use what was put in the pull request the issue still exists.

from xplr.

Maybe it's WM specific bug? Need to test it on different window managers. So far as we know,

KDE + KWin -> Working
SWAY (I3) -> Working
DWM -> Broken
GNOME -> Not tested
XFCE -> Not tested
I3 (stock) -> Broken
I3-status -> Not tested
BSPWM -> Not tested
AwesomeWM -> Not tested
qtile -> Not tested
xmonad -> Not tested

from xplr.

I wish I had more users in our discord channel, then I could just ping users to test report this 😄

from xplr.

Just tried kwin with alacritty and kitty and I am still running into the issue. I also tried switching to zsh and I am still running into the issue.

from xplr.

Wow, then it seems more like a platform issue? Which OS are you using?

from xplr.

And maybe shell?

from xplr.

I tried on both zsh and bash.

from xplr.

Very strange. I'm out of ideas. Can you record a video? I think GitHub allows posting video files.

from xplr.

GitHub broke 😄

from xplr.

No, I deleted the message because the aspect ratio was messed up.
https://user-images.githubusercontent.com/49350251/116135449-28d52400-a69f-11eb-9664-f58095b81292.mp4

from xplr.

@aflyingpumpkin you can maybe also capture a GIF using https://github.com/phw/peek. Preferably the KDE-Kwin one.

from xplr.

No, I deleted the message because the aspect ratio was messed up.
https://user-images.githubusercontent.com/49350251/116135449-28d52400-a69f-11eb-9664-f58095b81292.mp4

Runs on VLC

from xplr.

It the video xplr seems to work fine? You opened the file, then closed xplr?

from xplr.

The first example where they both closed at the same time was when I left xplr open and closed the terminal. The second example when the document stayed open was due to the fact that I fist closed xplr then closed the terminal.

from xplr.

Ah okay, so that's what you meant.

from xplr.

Yes I can reproduce this. I don't think you're supposed to close the terminal before quitting xplr gracefully.

from xplr.

The document will stay open. You close it separately. It's the expected behavior I guess.

from xplr.

Or, if you want to open multiple documents, you can do so, but you need to close them manually and quit xplr gracefully.

from xplr.

You can probably achieve what you want to, using nohup or screen or tmux. But I don't think it should be the default in xplr.

from xplr.

Alright, thanks

from xplr.

@aflyingpumpkin v0.9.1 probably fixed the issue in a way you wanted. You can close the terminal after opening apps in GUI, without closing them.

from xplr.

Great!

from xplr.