Comments (5)
you're right, this is not optimal. but as far as i know, there's no proper solution for this yet.
at least not without breaking the code of people using savon.
from nori.
That's why I was proposing an option that people can opt-in. Still a lot of work I know that.
from nori.
i don't know if it's a good idea to create a second output format. as far as i know, the current translation is based on the fact that nodes could contain attributes. i would have to dig into this, but i don't have the time to do it right now. one the new parser is ready to be used in production (savon 3.0), the input/output format probably needs to change in order to benefit from all that extra information. so if there are any changes to the request/response hashes, i'd like to introduce a single change.
from nori.
It's just too much work I think. And error prone. I take my idea back.
from nori.
as i said, i would definitely like to improve this, but i think it's maybe just a little too early.
i think once savon knows about all types, it should be able to solve this problem.
from nori.
Related Issues (20)
- Use schema HOT 5
- It ignores attributes when a child is a text node. HOT 11
- Strings as Nori::StringWithAttributes HOT 8
- xsi:nil="true" nodes not nil when additional attributes present HOT 2
- Why add Hash#to_params HOT 1
- Make advanced type casting actually advanced HOT 2
- strip error HOT 3
- advance_type_casting regex fails to parse time like fields HOT 3
- XML Parsing fails with unescaped ampersand in content (not tag) HOT 1
- Breaking change between 2.4.0 and 2.6.0 HOT 1
- Nori dynamic require breaks in Jruby HOT 3
- does not work with plain tags and whitespace
- Selective disabling of advanced_typcasting for certain attributes
- Strange error when passing malformed xml
- empty_tag_value not obeying xsi:nil ?
- Raise on error?
- REXML parsing error HOT 3
- strip_namespaces doesn't work for attributes HOT 1
- Inconsistent types when parsing empty tags HOT 2
- Nori::StringWithAttributes should implement `#as_json`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nori.