Small deion If I do edit-cell</co

[input] screen flickers in edit-cell about visidata HOT 2 OPEN

midichef commented on August 26, 2024

[input] screen flickers in edit-cell

from visidata.

Comments (2)

midichef commented on August 26, 2024

If this helps, I extracted a list of the important drawing calls to try to trace what was going on in editText(). But I ran out of steam.

editText():
  v = vd.editline(vd.activeSheet._scr, y, x, w, display=display, **kwargs)
  editline():
    disp_help = HelpCycler(scr, '')
    while True:
      disp_help.draw()
        vd.drawInputHelp(scr, '')
          curhelp = vd.getHelpPane('input', module='visidata')
          sheet.drawSidebarText(scr, curhelp, title='Input Keystrokes Help')
            sidebarscr = vd.subwindow(scr, x, y, w, h)   #(call this the A subwindow)
            text.draw(sidebarscr)  #(is actually curhelp.draw(sidebarscr) which is HelpPane.draw())
              #has lots of calls to:
              HelpPane.draw(vs.subwindow(scr))
                  #which makes a new B subwindow in the A subwindow:
                  vd.subwindow(scr of the new subwindow)
                  # and calls erase(), refresh() on its parent the A subwindow

from visidata.

midichef commented on August 26, 2024

Another related effect: some input prompts, like go-col-regex or go-col-number leads visidata's CPU usage to go up from 0% to a nonstop 20-30%. Surprisingly, search-col does not.

To reproduce: vd -N sample_data/sample.tsv, then go-col-regex and don't enter any characters.

This behavior started with the same commit, b859610.

That commit is dated Jan 14 so it's not the cause of #2243, which was reported Jan 9.

from visidata.

Recommend Projects