Seems to still drop some markers about passa HOT 5 CLOSED

Give me the source requirements for the resolution here

from passa.

Confirmed those are all from python_requires. apipkg got it via

apipkg ← execnet ← pytest-xdist ← '-e .[tests]'

pytest-xdist provided those values.

I think the theoretically best option is to add an extra field to the lockfile format (and requirementslib.Requirement). Otherwise we’ll need to merge them into the markers. It’s not difficult, just messy.

from passa.

I also still like this idea because it allows us to keep records of otherwise unresolvable dependencies together by just adding the extra marker. I still wonder if it makes sense to treat this special or to allow uniqueness in lockfiles the same way we do in the dep cache

As for this specific case, I assume you looked at the various ways pipenv handles that marker?

from passa.

(This is related to not picking up requires_python attributes from the requirementset after resolution -- see https://github.com/pypa/pipenv/blob/master/pipenv/patched/piptools/repositories/pypi.py#L396 for info)

from passa.

Implemented requires_python pickup in d339019 (with a cache), and merging them into markers in 2d90438. This should do it for now. (The logic can use some improvement, the markers are a bit ugly now.)

from passa.