Git Product home page Git Product logo

Comments (20)

Sarjuuk avatar Sarjuuk commented on May 22, 2024

My answer is basicly the same as for #45
Except, said site uses CN, so you could build on top of that.

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

In #45
you say
But if you do, there is also the comparatively minor hassle of registering the new locale, adding an additional locale-field to he affected tables, updating the setup to search for these DBC-fields and strings in TrinityCores DB, etc.
so
can you introduce what documents are involved, ,and I try to deal with, because now TC has eight language data

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

this should cover the code part
https://gist.github.com/Sarjuuk/5ae005d53a6ae5307568

whats missing

  • localized aowow-tables will need an additional *_loc4 field
  • localization/locale_zhcn.php
  • template/localized/contrib_4.tpl.php
  • static/js/locale_zhcn.js
  • static/css/locale_zhcn.css and linked imagery

/e: images are probably not available since html5-features made most of them obsolete.

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

I have a simple test
dbc convert well,db from tc world db and merge convert well
but some bugs:
1.dbc_achievement have data but aowow_achievement is nothing
2.in web although has zhcn but choose it and web refresh but also is enus
if choose other language ,shows well

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024
  1. I cannot test as i do not have a chinese client. I guess, you forgot to delete the dbc_* tables, that were generated previously.
  2. I overlooked a check in includes/ajaxHandler.class.php I've updated the gist with this change.

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024
  1. dbc_achievement only has CN data,convert from dbc seems well,but can not merge to aowow_achievment.
    this is my dbc_achievement.sql
    dbc_achievement.zip
  2. work now!
    and new issue:
    3)tooltip:like quest,spell,item shows English or name is BLANK.

I use enus client convert dbc and also aowow_achievement is empty
but dbc_achievment data well
4)dbc_itemsets data well but aowow_itemset like aowow_achievement is empty

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024
  1. Have you enabled CN in your config? The setup only looks for locales it is told to use and CN is new.
    add 0x10 to the locales variable or reapply the setup/db_structure.sql (was updated by the patch)

  2. is to be expected if the required strings are missing.

In any case it may be helpful if you could send me the full set of dbcs.

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

now my aowow_config -locale value is 349 cat 2 flag 169
I have enUS and zhCN wow client
and now there are two major issues:
1)tooltip:quest,item,npc,spell
for example
url is /db/?quests=10.3537
qq 20160104195337
you can see cn can be shown but tooltip is english,if you click it into
for example
url is /db/?quest=11611
qq 20160104195350
you can see all are CN,so tooltip has wrong can not show cn.

2)aowow_achievement,aowow_itemset is empty but dbc_* have data,I give you all 335 cn dbc for you test.
dbc335zhCN.zip

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

Updated the gist once again. This should fix the tooltips, achievements and itemsets.

How are the translations coming along?

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

thanks!
and
achievement
why your site is:
qq 20160106222655
but me
qq 20160106222709
only a little..........

about translate ,
I invited a few good friends, together with the translation, but the translation in large quantity, we usually have to busy, so they try to hurry up good translation and I check it and will submit the merger request, when the time comes for you to check.

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

This is not the site i actively develop on. It's the 'working presentation'.
But it looks like you encountered some sort of javascript error. Impossible to say what happened from the screenshot alone. This bug didn't occur on my dev-server
unbenannt

also you can probably use this as a basis: http://static.wowhead.com/js/locale_zhcn.js
also, also a couple of phrases can be taken directly from the client archives itself Interface/FrameXML/GlobalStrings.lua

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

maybe javascript error
but I don't know why cause it
I see global.js wrong ,use firefox F10 dev tool
when into achievement page
error is:
qq 20160110182906
I don't know why

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

and thats why you usually post the occurring error and/or the pages source via paste or gist or something

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

I have updated my comment

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

this is probably called from here global.js#14468 (since in the screenshot, the "Side" field is the first not being generated)
that would mean, that g_sides (which is in static/js/locale_zhcn.js, which you need to translate) either has no data or achievement.side is wrong (improbable, the related functions haven't been touched in ages).

Still, i wouldn't need to guess all that often, if you'd provide sensible information about these errors.

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

I give your my aowow_achievement_* 3 tables db sql for you test

my_db_aowow_achievement.zip

and locale js maybe not an issue? I copy enus.js and rename it to zhcn.js for quickly test

now translation are On going!

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

When unpacking your DBCs, your integers appear to not be read as expected.
It's not totally unexpected though.

/e: on second thought, the lines 508 - 510 may also need to be commented.

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

I have done it but achievement page also wrong
and my system is win 7 x64 and CN language.
could I give your my all aowow_db?

from aowow.

Sarjuuk avatar Sarjuuk commented on May 22, 2024

i've committed the changes to the extractor 278176a

as the error occurs either while extracting the dbcs or moving the extracted data from the (temporary) dbc_* tables to the aowow_* tables, please do the following.

  • delete the affected dbc-tables and truncate the aowow- ones

    DROP TABLE IF EXISTS dbc_achievement_category, dbc_achievement;
    TRUNCATE aowow_achievement;
    
  • regenerate the data using
    php aowow --sql=achievement

  • report back the values returned by those queries

    SELECT faction, map, 0 FROM dbc_achievement WHERE Id = 457 UNION
    SELECT faction, map, parentCat FROM aowow_achievement WHERE id = 457;
    

expected returns are

-1 -1 0
3 -1 -1

from aowow.

qyh214 avatar qyh214 commented on May 22, 2024

yes!now returns are true

from aowow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.