Is there an existing issue for this? <li class="

bug: UnionValidator#setValidationEnabled does not make its members respect that about shapeshift HOT 2 OPEN

sapphiredev commented on May 26, 2024

bug: UnionValidator#setValidationEnabled does not make its members respect that

from shapeshift.

Comments (2)

kyranet commented on May 26, 2024

Thing is, although the API is called setValidationEnabled, the getter method (getValidationEnabled()) is only called in tests, not a single time in the source code, and instead the library uses the getter below it (get shouldRunConstraints()):

shapeshift/src/validators/BaseValidator.ts

Lines 116 to 122 in afb87bf

 public getValidationEnabled() { 

 return getValue(this.isValidationEnabled); 

 } 

 protected get shouldRunConstraints(): boolean { 

 return getValue(this.isValidationEnabled) ?? getGlobalValidationEnabled(); 

 }

During validation, this.handle() is always called, even when get shouldRunConstraints() returns false:

shapeshift/src/validators/BaseValidator.ts

Lines 91 to 99 in afb87bf

 public parse<R extends T = T>(value: unknown): R { 

 // If validation is disabled (at the validator or global level), we only run the `handle` method, which will do some basic checks 

 // (like that the input is a string for a string validator) 

 if (!this.shouldRunConstraints) { 

 return this.handle(value).unwrap() as R; 

 } 

 return this.constraints.reduce((v, constraint) => constraint.run(v).unwrap(), this.handle(value).unwrap()) as R; 

 }

In fact, if this.handle() wasn't called at all if it returned false, the effects would not only apply to the current validator, but also the children, since their parse() method wouldn't be called either.

We should change the name or the behaviour IMO. cc: @vladfrangu @favna

from shapeshift.

favna commented on May 26, 2024

I'd say we should change the behaviour.

from shapeshift.

Recommend Projects

bug: UnionValidator#setValidationEnabled does not make its members respect that about shapeshift HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public getValidationEnabled() {
	return getValue(this.isValidationEnabled);
	}

	protected get shouldRunConstraints(): boolean {
	return getValue(this.isValidationEnabled) ?? getGlobalValidationEnabled();
	}

	public parse<R extends T = T>(value: unknown): R {
	// If validation is disabled (at the validator or global level), we only run the `handle` method, which will do some basic checks
	// (like that the input is a string for a string validator)
	if (!this.shouldRunConstraints) {
	return this.handle(value).unwrap() as R;
	}

	return this.constraints.reduce((v, constraint) => constraint.run(v).unwrap(), this.handle(value).unwrap()) as R;
	}