Git Product home page Git Product logo

Comments (5)

notque avatar notque commented on August 13, 2024

Need to validate policy handling, and make sure it's functioning for each part.

from hermes.

jobrs avatar jobrs commented on August 13, 2024

What is missing to make policy handling 'proper' @notque?

from hermes.

notque avatar notque commented on August 13, 2024

Tests that do a good job of validation, this goes back to the dummy/mock issue, making sure to properly mock these things so we have real validation the features work, like policy handling.

from hermes.

jobrs avatar jobrs commented on August 13, 2024

makes sense, we will need this for #23 anyway

from hermes.

notque avatar notque commented on August 13, 2024

This wasn't handled properly, and thus domain_id was removed a long time ago as it was a security issue, and I couldn't sort out the specifics needed.

Essentially, the way we handled the passing of the id was a problem. I rewrote it a few times, and could not get a scenario it would just work.

This is off now, and there is a new ticket to implement it correctly.

from hermes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.