Tests aren't found when running make about hermes HOT 6 CLOSED

go test -v ./pkg/api/ works to run tests in a folder, but running from the main dir doesn't explore. There is another command you can run with go 1.9. I'm on 1.8, so will upgrade, test the command, change the makefile to use it, validate it's on 1.9, and I think that's a solution.

from hermes.

upgrading to 1.9 allows the go test -v ./pkg/api to work on the command line. All of the tests were being testing individually, now together there is an error

panic: duplicate metrics collector registration attempted [recovered]

Sorting out how to fix now.

from hermes.

The problem is how we're registering prometheus for each endpoint instead of the standard in init. This is to attach labels on the prometheus metrics instead of having an individual metric for each end point.

This is not a problem normally because you don't run register multiple times, but in the case of multiple tests it's registering.

I need to either set a mock flag to know if to register it or not, or to move the registering to a different place.... hrm... still thinking of ideas.

from hermes.

Another option is we can attach labels after the fact, so we could init the tests and registration, then in the function just attach the label for each handler.

from hermes.

Wrote a teardown function to unregister the collectors for Prom, but it doesn't allow you to reregistar with the same name (to not get screwy metrics).

So back to the drawing board.

from hermes.

Corrected this, now running all tests. Their passing is a different issue I'll continue. Closing this one.

from hermes.