Comments (7)
yea (but in this case we want to maintain the code in the high version/ENUM)
from abap-file-formats-tools.
looks like some is used for internal logic
TYPES:
BEGIN OF ENUM enum_formatting_option STRUCTURE formatting_option,
no_formatting VALUE IS INITIAL,
camel_case VALUE 1,
END OF ENUM enum_formatting_option STRUCTURE formatting_option,
BEGIN OF ENUM enum_type_info STRUCTURE type_info,
string,
numeric,
boolean,
date_time,
END OF ENUM enum_type_info STRUCTURE type_info,
BEGIN OF ENUM enum_operation STRUCTURE operation,
initial,
write_element,
open_structure,
close_structure,
open_table,
close_table,
END OF ENUM enum_operation STRUCTURE operation.
and some, is external facing logic which is not needed?
get_enum_values
IMPORTING element_name TYPE string
element_description TYPE REF TO cl_abap_elemdescr
RETURNING VALUE(result) TYPE string_table
RAISING
zcx_aff_tools,
get_enum_descriptions
IMPORTING element_name TYPE string
element_description TYPE REF TO cl_abap_elemdescr
RETURNING VALUE(result) TYPE string_table,
from abap-file-formats-tools.
was hoping not to downport ENUMs but guess I'll add that, work work 🚈
from abap-file-formats-tools.
testcase, can be removed, out of scope?
METHOD enum_element.
* base type / base structure/ ohne (integer)
TYPES:
BEGIN OF ENUM category,
general ##NEEDED,
classic_badi ##NEEDED,
END OF ENUM category.
from abap-file-formats-tools.
This is two fold (both to be removed!):
- We allow ENUMs to be parsed. This can be removed, because as you said: It is out-of-scope.
-
Internal logic is somehow based on ENUMs e.g. here and it can be replaced by constants.See comment below
from abap-file-formats-tools.
keep the internal logic as is, I implemented automatic downport of ENUMS to constants earlier today,
from abap-file-formats-tools.
So (hypothetically) I could do a downport on my local machine and copy/paste the results to the repository, right?
from abap-file-formats-tools.
Related Issues (20)
- Remove the unit test in standalone report HOT 1
- Syntax Error while installing on SAP ABAP Platform Developer Edition HOT 5
- Msg class not merged into standalone report HOT 2
- replace two calls to cl_abap_regex=>create_pcre() HOT 2
- add unit tests for `zcl_aff_log`
- All (non-required) components of type enum should have a default HOT 1
- cl_oo_abap_doc_reader, reading source code of class/intf HOT 3
- [rl-reuse_tool-4] Violation against OSS Rules of Play
- rename some of the renamed unit tests HOT 1
- ZIF_AFF_WRITER~VALIDATE ?
- MaxLength is currently limited to 255 HOT 3
- SMBC, missing update or bug? HOT 6
- Cannot install on NW 752 SP04 HOT 1
- Generation dumps for file formats with multiple tables with the same field name
- Schema Validation for AOBJ fails HOT 2
- Provide checks for ABAP file formats HOT 1
- Readme fix link to example HOT 2
- Generator generates wrong readme file
- Add report that generates files for AFF HOT 1
- Fix the log for the `z_generate_repo` report
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-file-formats-tools.