Git Product home page Git Product logo

Comments (7)

larshp avatar larshp commented on September 23, 2024 1

yea (but in this case we want to maintain the code in the high version/ENUM)

from abap-file-formats-tools.

larshp avatar larshp commented on September 23, 2024

looks like some is used for internal logic

  TYPES:
    BEGIN OF ENUM enum_formatting_option STRUCTURE formatting_option,
      no_formatting VALUE IS INITIAL,
      camel_case    VALUE 1,
    END OF ENUM enum_formatting_option STRUCTURE formatting_option,

    BEGIN OF ENUM enum_type_info STRUCTURE type_info,
      string,
      numeric,
      boolean,
      date_time,
    END OF ENUM enum_type_info STRUCTURE type_info,

    BEGIN OF ENUM enum_operation STRUCTURE operation,
      initial,
      write_element,
      open_structure,
      close_structure,
      open_table,
      close_table,
    END OF ENUM enum_operation STRUCTURE operation.

and some, is external facing logic which is not needed?

      get_enum_values
        IMPORTING element_name        TYPE string
                  element_description TYPE REF TO cl_abap_elemdescr
        RETURNING VALUE(result)       TYPE string_table
        RAISING
                  zcx_aff_tools,

      get_enum_descriptions
        IMPORTING element_name        TYPE string
                  element_description TYPE REF TO cl_abap_elemdescr
        RETURNING VALUE(result)       TYPE string_table,

from abap-file-formats-tools.

larshp avatar larshp commented on September 23, 2024

was hoping not to downport ENUMs but guess I'll add that, work work 🚈

from abap-file-formats-tools.

larshp avatar larshp commented on September 23, 2024

testcase, can be removed, out of scope?

  METHOD enum_element.
*  base type / base structure/ ohne (integer)
    TYPES:
      BEGIN OF ENUM category,
        general ##NEEDED,
        classic_badi ##NEEDED,
      END OF ENUM category.

from abap-file-formats-tools.

albertmink avatar albertmink commented on September 23, 2024

This is two fold (both to be removed!):

  • We allow ENUMs to be parsed. This can be removed, because as you said: It is out-of-scope.
  • Internal logic is somehow based on ENUMs e.g. here and it can be replaced by constants. See comment below

from abap-file-formats-tools.

larshp avatar larshp commented on September 23, 2024

keep the internal logic as is, I implemented automatic downport of ENUMS to constants earlier today,

image

from abap-file-formats-tools.

albertmink avatar albertmink commented on September 23, 2024

So (hypothetically) I could do a downport on my local machine and copy/paste the results to the repository, right?

from abap-file-formats-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.