Comments (2)
In the unit test code, you don't have to use Container nor the @service or @Inject decorators.
The idea is that you mock every dependency of the class that you are going to test.
Also, you don't necessarily need to write a Class for the mock, just use a normal object with the involved functions mocked with jest
describe('Account', () => {
describe('#deviceChange', () => {
it('check everyting cool', async done => {
let logger = {};
let otpModel = {
updateOTPtoInactiveForModule: jest
.fn()
.mockImplementation(async(deviceChange : string, accountId : number) => new Promise((resolve : any) => resolve(true))),
getUserPhoneService: jest
.fn()
.mockResolvedValue(true)
};
let devicechangeModel = {
addDeviceChangeDetails: jest
.fn()
.mockResolvedValue(true),
updateDeviceChangeToInactive: jest
.fn()
.mockResolvedValue(true)
};
let DeviceChangeServiceInstance = new DeviceChangeService(devicechangeModel, otpModel, logger);
let deviceChangeStatus = DeviceChangeServiceInstance.deviceChange(accountId, deviceId, newdeviceId, created, mobile);
});
});
});
Now the problem that I see in your code is that you are using the service locator to obtain a dependency that should be injected into the constructor.
So, what I'm saying is that you need to change this
let OTPServiceInstance = Container.get(OTPService);
For this
constructor(
@Inject('devicechangeModel')private devicechangeModel,
@Inject('otpModel')private otpModel,
@Inject('logger')private logger,
@Inject() private OTPServiceInstance: OTPService, // Here is injected.
) {
}
The function Container.get (formal name 'Service Locator') should only be used in the entry point of the code execution
In this project, that is at top-level code in the API Route Controller.
Also in the event handlers, because the execution is detached from the API controller context
What do you think?
from bulletproof-nodejs.
Hello santiq,
Sorry for the delay, but as per ur instructions, i implemented it and works perfectly, and checked out other git repo like many have implemented the same way you have guided.
Thanks satiq,
from bulletproof-nodejs.
Related Issues (20)
- How to implement the swagger following this structure? HOT 2
- Email client replacement HOT 1
- Implementation with Mysql/pgsql with typescript HOT 3
- examples for creating new models in mongo HOT 1
- Project structure by feature HOT 2
- add absolute imports? HOT 1
- Where do you add utility functions and constants? HOT 1
- Absolute import "Cannot find module @/*" HOT 5
- Jwt invalid algorithm HOT 2
- Recreate code to be compatible with all os development environment
- Changing a request would require changes in 3 places of the code, is there a better solution? HOT 1
- api status handling
- Better testing project structure/ configuration? HOT 1
- Using a different database for tests HOT 1
- Where store Push Notification Token?
- Refactoring Sub/Pub Layer Poll HOT 1
- Is there same or similar example in js? HOT 1
- Redis client HOT 2
- adapt for mySQL HOT 2
- Update Mongoose for Heroku Deployment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bulletproof-nodejs.