Git Product home page Git Product logo

Comments (2)

santiq avatar santiq commented on May 20, 2024 1

In the unit test code, you don't have to use Container nor the @service or @Inject decorators.

The idea is that you mock every dependency of the class that you are going to test.

Also, you don't necessarily need to write a Class for the mock, just use a normal object with the involved functions mocked with jest

describe('Account', () => {
  describe('#deviceChange', () => {
    it('check everyting cool', async done => {
      let logger = {};
      let otpModel = {
        updateOTPtoInactiveForModule: jest
          .fn()
          .mockImplementation(async(deviceChange : string, accountId : number) => new Promise((resolve : any) => resolve(true))),
        getUserPhoneService: jest
          .fn()
          .mockResolvedValue(true)
      };
      let devicechangeModel = {
        addDeviceChangeDetails: jest
          .fn()
          .mockResolvedValue(true),
        updateDeviceChangeToInactive: jest
          .fn()
          .mockResolvedValue(true)
      };
      let DeviceChangeServiceInstance = new DeviceChangeService(devicechangeModel, otpModel, logger);
      let deviceChangeStatus = DeviceChangeServiceInstance.deviceChange(accountId, deviceId, newdeviceId, created, mobile);
    });
  });
});

Now the problem that I see in your code is that you are using the service locator to obtain a dependency that should be injected into the constructor.

So, what I'm saying is that you need to change this

 let OTPServiceInstance = Container.get(OTPService);

For this

  constructor(
    @Inject('devicechangeModel')private devicechangeModel, 
    @Inject('otpModel')private otpModel,
    @Inject('logger')private logger,
    @Inject() private OTPServiceInstance: OTPService, // Here is injected.
) {
}

The function Container.get (formal name 'Service Locator') should only be used in the entry point of the code execution
In this project, that is at top-level code in the API Route Controller.
Also in the event handlers, because the execution is detached from the API controller context

What do you think?

from bulletproof-nodejs.

lineldcosta avatar lineldcosta commented on May 20, 2024 1

Hello santiq,

Sorry for the delay, but as per ur instructions, i implemented it and works perfectly, and checked out other git repo like many have implemented the same way you have guided.

Thanks satiq,

from bulletproof-nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.