Comments (5)
I'll give it a try, but it might take me some time before coming out with something as there's quite a few projects I'm working on in parallel already, I'll give an update on whether I manage to deliver something or not here !
from sangria.
Sure, no problem, I'll try working on it this week !
from sangria.
ListType[_]
was changed quite recently for that: #904
I guess a similar change for ListInputType[_]
would make sense.
Would you want to open a PR for this?
from sangria.
So I just started working on it, unfortunately it might no be very straightforward, maybe I'm having the wrong approach here but it seems that we would also need an update of the sangria-marshalling-api
repository, as we might be missing an implicit for creating Arguments, the apply
method requires 3 implicit parameters:
toInput: ToInput[Default, _],
fromInput: FromInput[T],
res: ArgumentType[T]
But the trait FromInput
has the following implementation:
class SeqFromInput[T](delegate: FromInput[T]) extends FromInput[Seq[T]]
I don't mind giving a try at changing all that to Iterable, but I guess that could be bothersome to release, as it would need to rely first on a new version the the marshalling api that has the new implicit. It would also probably be quite a lot of changes.
Once again I don't mind trying, that could an interesting first contribution, but I don't know what's your take on that, let me know !
from sangria.
Indeed, this could be a bit complex.
And I can spot some .asInstanceOf[Seq[Any]]
in sangria-marshalling-api
, meaning that we cannot rely on types to catch all issues here... 😭
If you have time / energy to go down the rabbit hole, I'll help you. For example, I can cut a beta release of sangria-marshalling-api with some changes of your if you want to test something. Otherwise you can publish locally, and use the snapshot version.
But if you don't have the time / energy, I'll understand perfectly.
from sangria.
Related Issues (20)
- It is impossible to override an built-in scalar
- Decoding failure HOT 9
- Unnecessary implicit conversion while using experimental catseffect `AsyncValue` HOT 2
- Change context object
- Support OneOf on Input Objects HOT 1
- Website is down HOT 1
- Looking for help / maintainers
- Deprecating InputField removes the fields in version 4.1.0 HOT 1
- Build a Sangria Steward
- Scala 3 Derive Macro Compiler Error HOT 9
- Scala 3: Exception returning Future values from GraphQL Endpoint HOT 1
- [scala3] sangria-relay HOT 1
- Error behavior when `name` argument to ObjectType constructor contains a space HOT 5
- `Context.arg` Wraps Optional Arguments inside another Option HOT 4
- Query/Schema validation for default values on object type field arguments not captured (ValueOfCorrectType rule) HOT 2
- Using `Option` in fields fails in the `None` case HOT 8
- support @deprecated on argument and input field HOT 1
- The custom scalars do not parse underlying model HOT 3
- Long type user input coercion missing implicit conversion from java.math.BigDecimal HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sangria.