Comments (6)
kentonv
commented on June 3, 2024
Hmm, I suspect you can do DDP._CurrentInvocation.get().connection, but that is of course using a Meteor private API. Maybe we should add a Meteor.sandstormUser() server-side that calls this?
FWIW I highly recommend defining explicit methods to do mutations rather than allow/deny rules. With methods it's much easier to reason about whether the call fits the expected pattern, whether the parameter types are correct, etc. But we shouldn't be imposing that style in meteor-accounts-sandstorm.
from meteor-accounts-sandstorm.
ndarilek
commented on June 3, 2024
I like `Meteor.sandstormUser()` everywhere, it makes defining universal
helpers easier. Or I suppose you could do `AccountsSandstorm.user()` if
you'd rather not inject another method on `Meteor`. No strong feelings
either way, though the latter is at least in keeping with Meteor's use
of `Accounts`, `Mongo`, etc. for things that aren't core APIs.
And yes, definitely agreed on the methods. Methods are normally how I do
things too, but unfortunately CollectionFS is opinionated and doesn't
really document how to disagree with its opinions. :) File uploads are
initiated by `collection.insert` on the client, which of course subjects
the call to allow/deny rules.
Thanks for the workaround, I'll give it a shot.
from meteor-accounts-sandstorm.
simonv3
commented on June 3, 2024
Just wanted to pipe up that I was running into this as well and left scratching my head a bit until I came here. I'll look at the workaround.
(This is for annotate, so I'm also working with CollectionFS, though I saw @ndarilek comment somewhere that it's now depricated, sooooo)
from meteor-accounts-sandstorm.
ndarilek
commented on June 3, 2024
I think this issue may be invalid but I haven't dug into it.
A few days ago I was getting `undefined` at some stage in running the
workaround. I didn't investigate too far--it was planned for after I'd
implemented some other features. I was using coffeescript's `?` operator
so didn't figure out what stage of the chain was nulling out.
But I don't think allow/deny rules have access to the DDP connection, or
at least, are run within a context that has access. I think they're
passed the userId and do their calculations that way, meaning they
wouldn't work with anonymous users. They're kind of a dirty corner of
the framework I barely touch, so I don't know for sure. I usually use
methods.
from meteor-accounts-sandstorm.
kentonv
commented on June 3, 2024
If DDP._CurrentInvocation.get() doesn't work (and there's no other way to get at the connection) then I think we're out of luck. I don't know of anywhere else where we can stash the permissions. You'll need to rely on the user being logged in I guess?
from meteor-accounts-sandstorm.
simonv3
commented on June 3, 2024
DDP._CurrentInvocation.get() seemed to work fine for me in permissions, but somehow adding this package broke file uploading on CollectionFS in general. (linked to above). I'll have to investigate more later.
from meteor-accounts-sandstorm.
Related Issues (16)
- Could you add a CHANGELOG.md
- Create a way to only process Sandstorm headers if Sandstorm environment variable is set HOT 4
- Using package doesn't create the user instance expected. HOT 2
- Meteor 1.3 changes HOT 2
- Support for applications not running out of site root HOT 6
- Package seems to be ignoring validateloginattempt HOT 9
- This package should probably be republished under sandstorm namespace
- Expose X-Sandstorm-Session-Id as well HOT 1
- Browser randomly adding "; charset=UTF-8" to XHR request content-type? HOT 4
- Doesn't work with Meteor 1.5 HOT 2
- conflict constraint HOT 1
- Add additional helper functionality HOT 5
- Accounts.updateOrCreateUserFromExternalService() may be broken HOT 2
- Indicate when a sandstorm login has been attempted HOT 1
- Does not work with anonymous user permissions HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-accounts-sandstorm.