Git Product home page Git Product logo

Comments (14)

Samuell1 avatar Samuell1 commented on May 30, 2024 1

Fixed in new version 1.1.0!

from contenteditor-plugin.

Samuell1 avatar Samuell1 commented on May 30, 2024

Hey, what version do you using?

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

1.0.9

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

Now I was testing it and it doesn't save tags at all (Bold etc.)

from contenteditor-plugin.

Samuell1 avatar Samuell1 commented on May 30, 2024

Do you get any errors in console?

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

Nope

from contenteditor-plugin.

Samuell1 avatar Samuell1 commented on May 30, 2024

And without fixtures everything works fine?

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

Now when I was testing it it wasn't working neither. Tags like <p> </p> are there but <b> <i> are rendered at first when I save it but on reload they are not there anymore no matter what.

from contenteditor-plugin.

Samuell1 avatar Samuell1 commented on May 30, 2024

Do you using latest version of OctoberCMS?

I can look more on it tomorrow can you provide your code what you used?

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

Yes, build 431

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

I think that problem is on my side with jQuery. I'm very sorry and I'll report back

from contenteditor-plugin.

mpetricek avatar mpetricek commented on May 30, 2024

Ok I figured out why my jQuery was stripping "bold" tags and so on.

Now the only problems are not working "fixtures". They work when I'm logged but when not the fixture tags (p, h2) are stripped.

from contenteditor-plugin.

 avatar commented on May 30, 2024

Hi,

I just wanted to post the exact same issue and I discovered yours.

When you use fixture, for example that :

<div class="container">
    {% component 'editor' file="footer/footer-top" fixture="h2" %}
</div>

When you are logged in as admin (and so you have access to content editor), the rendered HTML is like that :

<div class="container">
  <h2 data-fixture="" data-ce-tag="p" data-component="editor::onSave" data-file=".frfooter/footer-top" data-tools="paragraph,bold">Contact-us</h2>
</div>

The same block when I'm logged out :

<div class="container">Contact-us</div>

As you can see, the whole h2 tag disappeared.

You can also notice that the rendered html have an empty data-fixture (that should probably be filled with "h2") and there is a data-tools attribute that should not be here.

It's probably because I have others parts of the page that I edit with content tools too, and it seems to bring conflicts.

EDIT : I think I understand what happens. If I go to CMS > Content and I edit my ".frfooter/footer-top" file, I see only "Contact-us" in it (without any tags).

Non admin users don't have any access to content editor (and it's great because I don't want everybody to be able to edit my website), but as a result, content editor can't be initialized and October CMS just load the content in my .frfooter/footer-top file (so "Contact-us" without any tags).

To patch this, I think that when you use the fixture property, you should save the fixture tag in the content file, so my .frfooter/footer-top file would contain

<h2>Contact-us</h2> 

instead of just "Contact-us"

from contenteditor-plugin.

 avatar commented on May 30, 2024

Wow what a reactivity ! I just posted 👍

from contenteditor-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.