Git Product home page Git Product logo

Comments (6)

jonathan-hc avatar jonathan-hc commented on May 30, 2024

+1

I used contenteditor "link" tool for some links that were styled as buttons using classes and as soon as I saved my edits, the classes were stripped off leaving the link a plain one.

from contenteditor-plugin.

 avatar commented on May 30, 2024

+1000 here, I just wanted to post the same issue and discover yours. Why closed without answers ?

Personaly, I use fixture a lot because I want my clients to be able to edit texts on their sites, but not the design neither the semantic, so I don't want to let them to play with different tags.

But I still want to be able to easily apply styles to that elements, and using class would greatly help for that purpose.

I would wrap the fixture in another tag with the class I want, but, as most october CMS user. I always try to remove a wrapper when I can (to have lighter, more readable, elegant code).

For this reason, adding class directly to the fixture element would be the best option.

Best regards,

Alex

from contenteditor-plugin.

CptMeatball avatar CptMeatball commented on May 30, 2024

Since opening this issues, we've tackled this problem by wrapping the element with a div. In CSS apply that styling to the html element. (like @Alex360hd already pointed out). It's the same principe, just a bit messier.

.lead h1 {
    // styles here
}

from contenteditor-plugin.

 avatar commented on May 30, 2024

PR added, even if the wrapper solution works. I think it's nicer to have class support directly in content editor component (at lease for fixture, where it make sense).

from contenteditor-plugin.

Samuell1 avatar Samuell1 commented on May 30, 2024

@Alex360hd Thanks for pr!

But I want to complete rework content editor when Content Tools will be ported to ES6. Then it should be easier to change, customize and many better features :)

from contenteditor-plugin.

 avatar commented on May 30, 2024

Nice !

Do you think you can commit the PR by waiting the new version ? I'm actually building a website by using this method, would like to know if the PR will be commited before I finish it or if I have to go back to the old method by adding a wrapper with the class I need.

from contenteditor-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.