Git Product home page Git Product logo

Comments (2)

Samuel-Maddock avatar Samuel-Maddock commented on May 25, 2024

Hi Erchi, thanks for this issue!

At line 112, why flip the sign if min_val > 0? I thought the sketch should be operated on the interval [min_val, max_val]?

Great point, this is indeed a bug leftover from old code that experimented with giving PrivateGBDT incorrect feature ranges to study how the performance behaves.

I have verified that this has a minimal effect on accuracy for the adult and Higgs dataset. I have fixed this as of 37f7117.

from federated-boosted-dp-trees.

erchiw avatar erchiw commented on May 25, 2024

Thank you a lot for checking this and verifying the results!

from federated-boosted-dp-trees.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.