Git Product home page Git Product logo

Comments (4)

samber avatar samber commented on May 12, 2024 1

I justed added:

  • OmitByKeys(map, keysToRemove)
  • OmitByValues(map, valuesToRemove)
  • OmitBy(map, predicate)
  • PickByValues(map, valuesToKeep)
  • PickBy(map, predicate)

from lo.

metalrex100 avatar metalrex100 commented on May 12, 2024

I may suggest PR if needed.

from lo.

samber avatar samber commented on May 12, 2024

Hi @metalrex100 and thanks for the contribution.

I would rather choose ValuesFilter for a more explicit naming

But I think this helper does too many things.

Why not implementing:

  • OmitByKeys(map, keysToRemove)
  • OmitByValues(map, valuesToRemove)
  • OmitBy(map, predicate)
  • PickByKeys(map, keysToKeep)
  • PickByValues(map, valuesToKeep)
  • PickBy(map, predicate)

Your ValuesF function could be replaced by:

subset := lo.PickByKeys(map[string]int{"foo": 1, "bar": 2, "baz": 3}, []string{"foo", "baz"})
values := lo.Values(subset)

WDYT ?

from lo.

metalrex100 avatar metalrex100 commented on May 12, 2024

@samber I thing that PickByKeys is a more clear naming for such functionality, indeed. Will change it.

from lo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.