Git Product home page Git Product logo

Comments (5)

samber avatar samber commented on May 20, 2024

1- I think you should just call do.Invoke[I] instead of do.InvokeAs[i], since your not performing interface matching here. I will improve the error message.

2- I'm not sure to understand the issue here. Your example output seems valid to me.

from do.

samber avatar samber commented on May 20, 2024

While i review comments on #45, I'm linking your issue to #45 (comment)

To describe the feedback from @mbark:

  • We provide *MyServiceImplem
  • Then invoke IMyService
  • We implement a *MyServiceMock via an override for test purposes.

Problem: do.InvokeAs will pick a random implementation of IMyService

from do.

samber avatar samber commented on May 20, 2024

Possible solutions:

  • invoke the latest injected service -> I don't like it, since the service injection order might be non-determinist
  • use do.OverrideNamedValue(i, do.NameOf[IMyService](), NewMyServiceMock) -> not developer friendly
  • use explicit aliases: do.AsNamed() -> might trigger error on override

@d-enk suggested reporting an error when multiple services match the interface.

Also, I would point out that since services injected in IoC containers are opaque, invoking an interface instead of a struct might lead to loading the wrong service if method signatures overlap. In that situation, an explicit alias is safer: do.AsNamed()

from do.

d-enk avatar d-enk commented on May 20, 2024

Another option, maybe you just need a separate method that returns a list of all match?
And in InvokeAs allow only one

looks like related #33

from do.

d-enk avatar d-enk commented on May 20, 2024

to fix 1 problem #81

from do.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.