Comments (6)
@tongboy - This issue should have been closed awhile ago because Goldiloader should work fine with Rails 5. The customization of the from
clause was fixed in rails/rails@f138bea which went into Rails 5.0.0. Can you file a new issue (with a reproducible test case) if you're still seeing any issues with Rails 5? Thanks.
from goldiloader.
This work is being done on the feature/rails-5
branch. Work includes:
- Gemspec and Travis updates
- Fix registration of association options
- Fix tests with overridden
from
clause - Compare ActiveRecord 4.2 and 5.0 for any interesting changes we should be aware of
- Fix
alias_method_chain
deprecation - See if #18 is fixed with Rails 5
- See if #14 is fixed with Rails 5
- See if #12 is fixed with Rails 5
- Get Rails 5 unit tests passing with Goldiloader
- Test JRuby 9000 with Rails 5 after jruby/activerecord-jdbc-adapter#708 is fixed.
from goldiloader.
It looks like customizing the from
of an association's scope is broken in Rails 5 causing two Goldiloader test failures. See rails/rails#22996.
from goldiloader.
Database cleaner is generating a deprecation warning when running tests in Rails 5. See DatabaseCleaner/database_cleaner#412.
from goldiloader.
Initial Rails 5 support added in 1d1ba60
from goldiloader.
@jturkel any help you need on this? I'm happy to help if there is. Goldiloader is our last gem dependency preventing our upgrade to rails 5 and it looks like we're facing issues based on the from
customization.
from goldiloader.
Related Issues (20)
- got an error while trying to load a polymorphic association HOT 2
- Eager load arbitrary nesting associations (with STI) HOT 11
- Goldiloader don't preload data HOT 1
- Auto-include only after a certain number of calls to the association? HOT 2
- Do not lose the goldiloader with additional includes HOT 2
- Rails edge build failing in database_cleaner-active_record
- Creates incorrect SQL for inverses of polymorphic associations HOT 1
- Preload Aggregations HOT 1
- config.filter_parameters keys ignored HOT 5
- Bug: before_destroy called more than once in some case scenario HOT 2
- `assert_mutability!` is being renamed to `assert_modifiable!` HOT 1
- [feature request] A less invasive "Suggestion" mode HOT 1
- New release that allows testing against rails main? HOT 3
- Rails 5.2 Support HOT 6
- Rails 5.2 with bundle install HOT 2
- Issue with Rails 6.0.0.rc1 HOT 5
- Goldiloader with ActiveStorage HOT 18
- This is not an issue HOT 1
- Compatibility with Rails 6.1 HOT 3
- Plans to release a version to enable Rails 6.1 as dependency? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goldiloader.