ActiveRecord 5.0 Support about goldiloader HOT 6 CLOSED

@tongboy - This issue should have been closed awhile ago because Goldiloader should work fine with Rails 5. The customization of the from clause was fixed in rails/rails@f138bea which went into Rails 5.0.0. Can you file a new issue (with a reproducible test case) if you're still seeing any issues with Rails 5? Thanks.

from goldiloader.

This work is being done on the feature/rails-5 branch. Work includes:

• Gemspec and Travis updates
• Fix registration of association options
• Fix tests with overridden from clause
• Compare ActiveRecord 4.2 and 5.0 for any interesting changes we should be aware of
• Fix alias_method_chain deprecation
• See if #18 is fixed with Rails 5
• See if #14 is fixed with Rails 5
• See if #12 is fixed with Rails 5
• Get Rails 5 unit tests passing with Goldiloader
• Test JRuby 9000 with Rails 5 after jruby/activerecord-jdbc-adapter#708 is fixed.

from goldiloader.

It looks like customizing the from of an association's scope is broken in Rails 5 causing two Goldiloader test failures. See rails/rails#22996.

from goldiloader.

Database cleaner is generating a deprecation warning when running tests in Rails 5. See DatabaseCleaner/database_cleaner#412.

from goldiloader.

Initial Rails 5 support added in 1d1ba60

from goldiloader.

@jturkel any help you need on this? I'm happy to help if there is. Goldiloader is our last gem dependency preventing our upgrade to rails 5 and it looks like we're facing issues based on the from customization.

from goldiloader.