Git Product home page Git Product logo

Comments (7)

Gummibeer avatar Gummibeer commented on May 19, 2024 1

Okay, so right now the change would be (some way) even worse. 😅
But good to know and I think that in V2 an authenticator like that would make sense.

from saloon.

Sammyjo20 avatar Sammyjo20 commented on May 19, 2024

Ooh yeah that could be good! So it just adds a query parameter with the key and value?

from saloon.

Gummibeer avatar Gummibeer commented on May 19, 2024

Exactly. Wasn't sure about naming but yeah, like ?key=abc123

from saloon.

Sammyjo20 avatar Sammyjo20 commented on May 19, 2024

I can definitely add that in - but I do think defaultQuery on the connector is a good approach too, you would just need to accept the API key through the constructor of the connector.

from saloon.

Gummibeer avatar Gummibeer commented on May 19, 2024

Yeah, doing it right now that way. But The authenticator feels better. And one question regarding priority.
If I use defaultQuery() to define key=1, the query authenticator with key=2 and in the request itself also defaultQuery() with key=3 - which one would be used? My hope would be that the authenticator has priority over both defaultQuery() methods - as it explicitly calls addQuery(). 🤔

from saloon.

Sammyjo20 avatar Sammyjo20 commented on May 19, 2024

I think that defaultQuery will take priority over the authenticator unfortunately. This is something that has been looked over a lot in v2 and the authenticator is basically the last thing in v2. Apologies

Screen Shot 2022-11-06 at 18 49 34

from saloon.

Sammyjo20 avatar Sammyjo20 commented on May 19, 2024

This has now been added to the v2 branch!

from saloon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.