[FEATURE] MultiSite Context should include locale object instead of id about pwa-kit HOT 3 CLOSED

Hi @nx-renezwinge,

Thanks for the input. Your suggestion makes sense. I'd like to run it by the eng that did this recent work. He'll be back in the office Sept 12th @adamraya.

One thing that I would like to mention, is that we do have a future work item to move this feature into the SDK or some other reusable library so that updates and be more easily consumed. So that is probably he time we'd be looking at taking in your suggestion.

I'll keep this issue open so we can get a response from Adam.

Thanks!

Ben

Edit: Updated date my colleague will be back in the office.

from pwa-kit.

Thank your @nx-renezwinge for reporting the issue. You are correct. PR #667 introduced the new MutliSite context but did not consider the locale alias configuration.

The suggested solution has been implemented in #716 .
Now the <MutiSiteContext> has the complete locale object available. If the locale.alias is defined in the sites.js configuration file, using the locale.alias in the URL is prioritized over the locale.id.

The solution is merged and will be included in the next release.

New generated projects from the future release will include the fix, but existing projects will need to add the fix manually.
It looks like you already applied the refactor in your project, but let me know if I can help to apply the fix.

from pwa-kit.

Hi @adamraya,
thx for the fast fix :) The changes looking mostly the same.
On the next update we add your code then :)

Best regards René

from pwa-kit.