Japanese text was overwritten by default text in code at pushing bundle about pwa-kit HOT 3 CLOSED

@syunyama

This is a long PR that is implementing multi-site support for the retail react app. I've linked the file directly were we are fixing the scripts that previously result in having a translation file with the wrong language in it (if you are to change you default locale).

We are currently working on releasing this code. So keep an eye out.

from pwa-kit.

Hi Shumpei Yamada

Thank you for pointing this out. This is a problem that is already on our radar and we have a PR that will be merged shortly that will stop this kind of error from happening.

The change is essentially locking down the locale used in the compile and extract scripts in the package.json file like below:

"compile-translations:pseudo": "formatjs compile --ast app/translations/en-US.json --out-file app/translations/compiled/en-XB.json --pseudo-locale en-XB",
"extract-default-translations": "formatjs extract 'app/**/*.{js,jsx}' --out-file app/translations/en-US.json --id-interpolation-pattern [sha512:contenthash:base64:6]",

The reason why this makes sense is because the default locale in this sense is the locale in which the code's "default messages" are written in. In the future we are going to look into being able to generate projects with defaultMessages in the users selected locale.

If you have any more questions please let me know.

Ben

from pwa-kit.

@bendvc
Thank you.
Please attach PR to this thread and close after merge.

from pwa-kit.