Git Product home page Git Product logo

Comments (3)

hdara-sfdc avatar hdara-sfdc commented on September 26, 2024

So DELETE and PUT is the way to go.

Not sure what you mean by this, are you suggesting to use one of these methods instead of GET ?

We just need a better mechanism for handling the error.May be instead of raise, just catch the exception and gently let the calling function know?

Perhaps you have something like returning a None to the caller in mind, but throwing an exception is in general better and consistent with many other APIs. However, instead of a generic ArgusException, it could throw a special exception meant to indicate this very condition, say ArgusObjectNotFoundException. The caller can then catch this and handle it appropriately, which is similar to checking for a None return value.

from python-argusclient.

rrajeevan avatar rrajeevan commented on September 26, 2024
  1. I meant whatever we are trying to do with lookup to see if alert exists and delete it and then recreate is the right way.

  2. +1 to the idea of the new Exception. I'll send you a PR soon, let me know what you think.

from python-argusclient.

hdara-sfdc avatar hdara-sfdc commented on September 26, 2024

Sure, please send the PR, thank you. You will need to update the unit tests too.

from python-argusclient.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.