Git Product home page Git Product logo

Comments (6)

nephros avatar nephros commented on May 28, 2024 1

But so I suppose it makes sense to introduce that cleanup also here at PM3, correct?

I have it in a "trivial fixups" branch - i'll put it in one of my next PRs that seems appropriate.

from patchmanager.

nephros avatar nephros commented on May 28, 2024

Should be fixed in cb01a77.

from patchmanager.

b100dian avatar b100dian commented on May 28, 2024

Closing,
@hsjpekka There's a build[1] in chum:testing if you want to test it out, feel free to re-open this bug if it doesn't work for you. Thanks!

https://build.sailfishos.org/package/show/sailfishos:chum:testing/patchmanager

from patchmanager.

Olf0 avatar Olf0 commented on May 28, 2024

Is this altered line in a commit by elros34 for "PM2-forever" related to this?

Here is the corresponding line in PM3 for the commit resolving this issue.

Just wondering, if this change for PM2 is also useful for PM3, but lack the understanding to determine & decide that.

from patchmanager.

nephros avatar nephros commented on May 28, 2024

Is this altered line in a commit by elros34 for "PM2-forever" related to this?

Yep, seems likely, that is just a very minor cleanup of code duplication that was introduced in cb01a77

from patchmanager.

Olf0 avatar Olf0 commented on May 28, 2024

Is this altered line in a commit by elros34 for "PM2-forever" related to this?

Yep, seems likely, that is just a very minor cleanup of code duplication that was introduced in cb01a77

Thanks for looking up, when and by whom this line was introduced.

But so I suppose it makes sense to introduce that cleanup also here at PM3, correct?

from patchmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.