Git Product home page Git Product logo

Comments (3)

Sachin19 avatar Sachin19 commented on August 22, 2024

Thanks for pointing this out! I have fixed it.

from seq2seq-con.

serjtroshin avatar serjtroshin commented on August 22, 2024

Thanks! Also here you iterate over n_best hypotheses. But since you want to kill beam when eos is in the top hypothesis, you might end up killing beam when less than n_best hypotheses are finalized. This will raise an error here and here since predScore[b] is in fact not always of the n_best size.

from seq2seq-con.

Sachin19 avatar Sachin19 commented on August 22, 2024

Thank you for reporting this! As has been mentioned in the paper, this code is adapted from open-nmt (with some code remnants for beam search) but we don't report beam search results. And the issues you report only appear when you try to do beam search and print multiple-hypothesis the code for which can be buggy as you pointed out. I intend to work on beam search and fix this in the future. For now I recommend that you use n_best=1 for correct behavior.

from seq2seq-con.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.