Git Product home page Git Product logo

Comments (7)

DavidBruchmann avatar DavidBruchmann commented on August 12, 2024

Docu v12
Docu v11

from typo3-rector.

simonschaufi avatar simonschaufi commented on August 12, 2024

The website getrector.com doesn't include TYPO3 stuff, so this can't work. This used to work in the past though but the template is outedated. sorry.

Changelogs:

Can you please have a a look at both?

I guess this one causes the problem: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056

from typo3-rector.

DavidBruchmann avatar DavidBruchmann commented on August 12, 2024

Yes I agree, I just don't know how to make TYPO3 and rector happy with the same notation.
Perhaps @brotkrueml can shine a light on it?

The contradiction seems being inside TYPO3 itself already, I think.

from typo3-rector.

simonschaufi avatar simonschaufi commented on August 12, 2024

The best is to have a look at the styleguide extension.

Having a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056/2/typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php#b505 it might be that my migration is wrong. Let me add a test case...

from typo3-rector.

DavidBruchmann avatar DavidBruchmann commented on August 12, 2024

your example looks outdated as it never has the label key

from typo3-rector.

simonschaufi avatar simonschaufi commented on August 12, 2024

No, in this case both rules depend on each other. This should just remove index 1 and the other one linked above should then change index 0 to "label".

from typo3-rector.

DavidBruchmann avatar DavidBruchmann commented on August 12, 2024

ok, I can't follow completely, as my example looks differently, but let's see what you're coming forward with

from typo3-rector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.