Git Product home page Git Product logo

Comments (11)

s-yata avatar s-yata commented on June 16, 2024

Thank you for your report.
Warnings to narrowing conversion may not be the cause of test failures.
I'll check tests later.

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

I added explicit typecasts to suppress warnings for narrowing conversion.
Would you check whether it sill compiles with a number of invalid-cast warning?

In addition, I'm not sure but some errors might be due to the file mode.
pytries/marisa-trie#1 (comment)

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

Sorry, it must not be due to the file mode, because it passes tests on 32-bit environments.

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

It seems that the following decrement is wrong.
https://github.com/s-yata/marisa-trie/blob/master/lib/marisa/grimoire/vector/bit-vector.cc#L200

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

Would you check if tests still fail or not with the latest version?

from marisa-trie.

superbobry avatar superbobry commented on June 16, 2024

Yes, with the master version of marisa-trie all the 64-bit tests succeed. Thank you very much!

Can you do a bugfix release?

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

I'll do it in a few days.

from marisa-trie.

superbobry avatar superbobry commented on June 16, 2024

Just a friendly reminder that we're waiting on the new release to update the Python wrapper :)

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

Sorry for my very very late reaction.

I've added a tag v0.2.5.

https://github.com/s-yata/marisa-trie/releases/tag/v0.2.5

from marisa-trie.

superbobry avatar superbobry commented on June 16, 2024

No worries. Thank you for releasing the fix!

from marisa-trie.

s-yata avatar s-yata commented on June 16, 2024

I've added a release v0.2.5.

https://github.com/s-yata/marisa-trie/releases/tag/v0.2.5

marisa-0.2.5.tar.gz is an archive generated by make dist.

from marisa-trie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.